Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 638343003: Mojo: Add some tests for ChannelEndpointId, etc. (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mojo: Add some tests for ChannelEndpointId, etc. (Just before I muck with it further, of course.) R=brettw@chromium.org Committed: https://crrev.com/be74a21329e462e03c70818a499b0aee470a10e3 Cr-Commit-Position: refs/heads/master@{#298994}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -10 lines) Patch
M mojo/edk/mojo_edk.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/edk/system/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/edk/system/channel_endpoint_id.h View 4 chunks +9 lines, -10 lines 0 comments Download
A mojo/edk/system/channel_endpoint_id.cc View 1 chunk +20 lines, -0 lines 0 comments Download
A mojo/edk/system/channel_endpoint_id_unittest.cc View 1 chunk +101 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
6 years, 2 months ago (2014-10-09 19:35:13 UTC) #1
brettw
lgtm
6 years, 2 months ago (2014-10-09 22:13:03 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/be74a21329e462e03c70818a499b0aee470a10e3 Cr-Commit-Position: refs/heads/master@{#298994}
6 years, 2 months ago (2014-10-09 22:26:01 UTC) #3
viettrungluu
6 years, 2 months ago (2014-10-09 22:26:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
be74a21329e462e03c70818a499b0aee470a10e3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698