runtime/bin/socket.cc - Issue 638303002: Don't create unused OSError in Socket_Available.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/socket.cc

Issue 638303002: Don't create unused OSError in Socket_Available. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/socket.cc

diff --git a/runtime/bin/socket.cc b/runtime/bin/socket.cc

index cbef2bacfc8b63ad1651dedaa61f8c35262f3d6c..0f3115e5351de3aa8796ab96ea839ca6a7c661c6 100644

--- a/runtime/bin/socket.cc

+++ b/runtime/bin/socket.cc

@@ -83,7 +83,7 @@ void FUNCTION_NAME(Socket_Available)(Dart_NativeArguments args) {

if (available >= 0) {

Dart_SetReturnValue(args, Dart_NewInteger(available));

} else {

- Dart_SetReturnValue(args, DartUtils::NewDartOSError());

+ Dart_SetReturnValue(args, Dart_Null());

}

« no previous file with comments | « no previous file | runtime/bin/socket_patch.dart » ('j') | runtime/bin/socket_patch.dart » ('J')