Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 638273004: Move stash_backend into extensions/browser/mojo. (Closed)

Created:
6 years, 2 months ago by Sam McNally
Modified:
6 years, 2 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, chromium-apps-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move stash_backend into extensions/browser/mojo. Committed: https://crrev.com/680be408457f4272b468e72468eb22e1c0f0b67a Cr-Commit-Position: refs/heads/master@{#301024}

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -336 lines) Patch
M extensions/browser/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + extensions/browser/mojo/stash_backend.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + extensions/browser/mojo/stash_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/browser/mojo/stash_backend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D extensions/browser/stash_backend.h View 1 chunk +0 lines, -45 lines 0 comments Download
D extensions/browser/stash_backend.cc View 1 chunk +0 lines, -73 lines 0 comments Download
D extensions/browser/stash_backend_unittest.cc View 1 chunk +0 lines, -174 lines 0 comments Download
M extensions/common/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
A + extensions/common/mojo/stash.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
D extensions/common/stash.mojom View 1 chunk +0 lines, -32 lines 0 comments Download
M extensions/extensions.gyp View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Sam McNally
6 years, 2 months ago (2014-10-23 07:49:17 UTC) #3
Ken Rockot(use gerrit already)
lgtm
6 years, 2 months ago (2014-10-23 19:27:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638273004/40001
6 years, 2 months ago (2014-10-24 00:54:36 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001)
6 years, 2 months ago (2014-10-24 01:46:56 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 01:47:34 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/680be408457f4272b468e72468eb22e1c0f0b67a
Cr-Commit-Position: refs/heads/master@{#301024}

Powered by Google App Engine
This is Rietveld 408576698