Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 638253004: Small optimization for <webview> tooltips. (Closed)

Created:
6 years, 2 months ago by paulmeyer
Modified:
6 years, 2 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Small optimization for <webview> tooltips. The IPC that is used to send tooltip text to BrowserPlugin was sent on every mouse movement, and unnecessarily sent the same text repeatedly. This is now checked and only new text is actually sent. Committed: https://crrev.com/e80cfc998098de11ac8cb637eabc0c4f19041a35 Cr-Commit-Position: refs/heads/master@{#299054}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/browser/browser_plugin/browser_plugin_guest.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
paulmeyer
+fsamuel@
6 years, 2 months ago (2014-10-09 17:24:35 UTC) #2
Fady Samuel
lgtm
6 years, 2 months ago (2014-10-10 01:35:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638253004/1
6 years, 2 months ago (2014-10-10 02:13:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 03:37:51 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 03:38:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e80cfc998098de11ac8cb637eabc0c4f19041a35
Cr-Commit-Position: refs/heads/master@{#299054}

Powered by Google App Engine
This is Rietveld 408576698