Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 638253002: Revert "Mixed Content: Use a static method to check form actions." (Closed)

Created:
6 years, 2 months ago by hshi1
Modified:
6 years, 2 months ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert "Mixed Content: Use a static method to check form actions." This reverts commit a26c8b8f48571a58267fc527d363c53c893bbd3a. Revert "Mixed Content: Extract frame processing from ::shouldBlockFetch." This reverts commit 828cf97a2a2dfe6316bb2d510ef0bd0061c4046f. Reason for revert: see https://code.google.com/p/chromium/issues/detail?id=421550 BUG=421550 BUG=411184 TBR=mkwst@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183440

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -88 lines) Patch
M LayoutTests/http/tests/security/mixedContent/insecure-css-image-with-reload-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/security/mixedContent/insecure-formSubmission-in-main-frame-allowed-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
A + LayoutTests/http/tests/security/mixedContent/insecure-formSubmission-in-main-frame-blocked.html View 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/security/mixedContent/insecure-formSubmission-in-main-frame-blocked-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/security/mixedContent/insecure-formSubmission-in-main-frame-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/mixedContent/insecure-frame-in-data-iframe-in-main-frame-blocked-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/mixedContent/insecure-script-in-data-iframe-in-main-frame-blocked-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 2 chunks +7 lines, -6 lines 0 comments Download
M Source/core/html/parser/HTMLResourcePreloader.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/MixedContentChecker.h View 4 chunks +2 lines, -9 lines 0 comments Download
M Source/core/loader/MixedContentChecker.cpp View 4 chunks +28 lines, -67 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638253002/1
6 years, 2 months ago (2014-10-09 00:09:19 UTC) #2
Mike West
LGTM. This is embarrassing, and I apologize for the breakage. I was fairly certain that ...
6 years, 2 months ago (2014-10-09 05:04:15 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 06:39:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183440

Powered by Google App Engine
This is Rietveld 408576698