Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 638233002: Preroll decoders when video starts playing (Closed)

Created:
6 years, 2 months ago by qinmin
Modified:
6 years, 2 months ago
Reviewers:
wolenetz
CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Preroll decoders when video starts playing When video starts playing, HTMLMediaElement no longer issues a seek(0) call. As a result, decoders needs to be prerolled so that video and audio will start outputting frames at the same time. This change also fixes an issue that when EOS is reached, the decoder does not clean up the prerolling state internal b/17812723 BUG= Committed: https://crrev.com/bbc157765fb43670db2f14deae6a6b3e9d5e91c1 Cr-Commit-Position: refs/heads/master@{#299006}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M media/base/android/media_decoder_job.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/base/android/media_source_player.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/android/media_source_player_unittest.cc View 4 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
qinmin
PTAL
6 years, 2 months ago (2014-10-08 22:39:07 UTC) #2
wolenetz
lgtm
6 years, 2 months ago (2014-10-09 21:01:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638233002/1
6 years, 2 months ago (2014-10-09 21:54:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-09 23:18:33 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 23:19:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bbc157765fb43670db2f14deae6a6b3e9d5e91c1
Cr-Commit-Position: refs/heads/master@{#299006}

Powered by Google App Engine
This is Rietveld 408576698