Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Issue 63823003: Remove global #define WebKit blink (Closed)

Created:
7 years, 1 month ago by abarth-chromium
Modified:
7 years, 1 month ago
Reviewers:
jamesr
CC:
chromium-reviews
Visibility:
Public.

Description

Remove global #define WebKit blink Now that we've updated all the code from the WebKit namespace to the blink namespace, we can remove this global #define. TBR=jamesr@chromium.org BUG=295096 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233627

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
abarth-chromium
7 years, 1 month ago (2013-11-07 07:22:45 UTC) #1
abarth-chromium
This will need to wait for a Blink roll, but then we should be all ...
7 years, 1 month ago (2013-11-07 07:23:06 UTC) #2
abarth-chromium
Moving to TBR to see if we can get this landed before more uses of ...
7 years, 1 month ago (2013-11-07 15:15:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/63823003/1
7 years, 1 month ago (2013-11-07 15:16:14 UTC) #4
abarth-chromium
Committed patchset #1 manually as r233627 (presubmit successful).
7 years, 1 month ago (2013-11-07 17:01:37 UTC) #5
jamesr
7 years, 1 month ago (2013-11-07 17:14:00 UTC) #6
lgtm

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698