Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 638213002: remove more OVERRIDE instances in remoting/ (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore
Modified:
6 years, 2 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

remove more OVERRIDE instances in remoting/ BUG=417463 Committed: https://crrev.com/4facceedfbacf05f00c4a5c699cc97dfcdec05a0 Cr-Commit-Position: refs/heads/master@{#298829}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M remoting/protocol/third_party_authenticator_base.h View 1 chunk +6 lines, -6 lines 0 comments Download
M remoting/protocol/third_party_authenticator_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M remoting/protocol/third_party_client_authenticator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/protocol/third_party_host_authenticator.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mostyn Bramley-Moore
@kelvinp: sorry to bother you again, but I missed some OVERRIDE instances in remoting/protocol (I ...
6 years, 2 months ago (2014-10-08 22:27:36 UTC) #2
kelvinp
lgtm
6 years, 2 months ago (2014-10-09 01:13:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638213002/1
6 years, 2 months ago (2014-10-09 06:03:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as db00967a1e3460b101d0638767da0866b24a8c55
6 years, 2 months ago (2014-10-09 09:33:32 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 09:34:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4facceedfbacf05f00c4a5c699cc97dfcdec05a0
Cr-Commit-Position: refs/heads/master@{#298829}

Powered by Google App Engine
This is Rietveld 408576698