Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 638193004: Keyed loads from super with numeric keys. (Closed)

Created:
6 years, 2 months ago by Dmitry Lomov (no reviews)
Modified:
6 years, 2 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Keyed loads from super with numeric keys. R=ishell@chromium.org, arv@chromium.org BUG=v8:3330 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=24522

Patch Set 1 #

Patch Set 2 : Minor test update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -34 lines) Patch
M src/runtime/runtime-classes.cc View 3 chunks +46 lines, -22 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/super.js View 1 3 chunks +103 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Dmitry Lomov (no reviews)
PTAL. Turned out we already have machinery in place for this, so not difficult.
6 years, 2 months ago (2014-10-09 12:42:03 UTC) #1
Igor Sheludko
lgtm
6 years, 2 months ago (2014-10-09 14:30:37 UTC) #2
Dmitry Lomov (no reviews)
On 2014/10/09 14:30:37, Igor Sheludko wrote: > lgtm Igor, thanks for the review. Erik, could ...
6 years, 2 months ago (2014-10-09 15:00:06 UTC) #3
Dmitry Lomov (no reviews)
On 2014/10/09 15:00:06, Dmitry Lomov (chromium) wrote: > On 2014/10/09 14:30:37, Igor Sheludko wrote: > ...
6 years, 2 months ago (2014-10-10 10:29:48 UTC) #4
Dmitry Lomov (no reviews)
Committed patchset #2 (id:20001) manually as 24522 (presubmit successful).
6 years, 2 months ago (2014-10-10 10:40:39 UTC) #5
arv (Not doing code reviews)
6 years, 2 months ago (2014-10-14 16:11:13 UTC) #6
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698