Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Issue 638133004: [Mac] The profile name field shouldn't be multi line because that's silly. (Closed)

Created:
6 years, 2 months ago by noms (inactive)
Modified:
6 years, 2 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Mac] The profile name field shouldn't be multi line because that's silly. BUG=424147 TEST=Start Chrome with --enable-new-avatar-menu. In the avatar menu, edit the profile name and try to press Alt+Enter to get a new line. This shouldn't work. Committed: https://crrev.com/5c41e6e456734ffeafda71cec10c2259494657da Cr-Commit-Position: refs/heads/master@{#299981}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
noms (inactive)
The streak of one-line Cocoa fixes continues! :)
6 years, 2 months ago (2014-10-16 19:05:23 UTC) #2
groby-ooo-7-16
lgtm LGTM - but caveat: This affects layout. I take it things look still OK?
6 years, 2 months ago (2014-10-16 20:04:39 UTC) #3
noms (inactive)
On 2014/10/16 20:04:39, groby wrote: > lgtm > > LGTM - but caveat: This affects ...
6 years, 2 months ago (2014-10-16 20:06:55 UTC) #4
groby-ooo-7-16
If you didn't change font size, you should be OK.
6 years, 2 months ago (2014-10-16 20:22:53 UTC) #5
groby-ooo-7-16
If you didn't change font size, you should be OK.
6 years, 2 months ago (2014-10-16 20:22:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638133004/1
6 years, 2 months ago (2014-10-16 20:57:44 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 21:53:04 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 21:53:09 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c41e6e456734ffeafda71cec10c2259494657da
Cr-Commit-Position: refs/heads/master@{#299981}

Powered by Google App Engine
This is Rietveld 408576698