Issue 638133003: Add DidNavigateMainFrame to the TabObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 638133003: Add DidNavigateMainFrame to the TabObserver. (Closed)

Created:
6 years, 2 months ago by Ted C

Modified:
6 years, 2 months ago

Reviewers:
David Trainor- moved to gerrit

CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Add DidNavigateMainFrame to the TabObserver. BUG=411056 Committed: https://crrev.com/d09b9fbec506fc3ae22d4322fbe8f6dc2455697e Cr-Commit-Position: refs/heads/master@{#299813}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -0 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/Tab.java	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java	View	1 chunk	+15 lines, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638133003/1

6 years, 2 months ago (2014-10-16 00:31:17 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-16 01:51:25 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d09b9fbec506fc3ae22d4322fbe8f6dc2455697e
Cr-Commit-Position: refs/heads/master@{#299813}