content/browser/accessibility/browser_accessibility_win.cc - Issue 638103003: ARIA role region is not exposed correct with MSAA+IA2 role

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_win.cc

Issue 638103003: ARIA role region is not exposed correct with MSAA+IA2 role (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_cocoa.mm ('k') | content/browser/accessibility/dump_accessibility_tree_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_win.cc

diff --git a/content/browser/accessibility/browser_accessibility_win.cc b/content/browser/accessibility/browser_accessibility_win.cc

index 4438d5a0f702dec7db65775adb3fb2ec62e7073a..edcc52ae018929f477defe2f3b8affecf328c72f 100644

--- a/content/browser/accessibility/browser_accessibility_win.cc

+++ b/content/browser/accessibility/browser_accessibility_win.cc

@@ -3687,9 +3687,11 @@ void BrowserAccessibilityWin::InitRoleAndState() {

ia2_role_ = IA2_ROLE_SECTION;

break;

case ui::AX_ROLE_REGION:

- ia_role_ = ROLE_SYSTEM_GROUPING;

- ia2_role_ = IA2_ROLE_SECTION;

- ia_state_ |= STATE_SYSTEM_READONLY;

+ if (html_tag == L"section") {

+ ia_role_ = ROLE_SYSTEM_GROUPING;

+ ia2_role_ = IA2_ROLE_SECTION;

+ }

+ ia_role_ = ROLE_SYSTEM_PANE;

dmazzoni 2014/10/20 16:33:23 I still think we need an "else" here

break;

case ui::AX_ROLE_ROW:

ia_role_ = ROLE_SYSTEM_ROW;