Source/modules/serviceworkers/CacheStorage.h - Issue 638023003: [ServiceWorkerCacheStorage] Blink changes to remove create/get and add open function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/CacheStorage.h

Issue 638023003: [ServiceWorkerCacheStorage] Blink changes to remove create/get and add open function (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/serviceworker/resources/cache-storage-worker.js ('k') | Source/modules/serviceworkers/CacheStorage.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/CacheStorage.h

diff --git a/Source/modules/serviceworkers/CacheStorage.h b/Source/modules/serviceworkers/CacheStorage.h

index 9d3726718045a72e377c6e99f8ebb5037ebdbe9f..6171181fe89206165bc22dd614946bf043403510 100644

--- a/Source/modules/serviceworkers/CacheStorage.h

+++ b/Source/modules/serviceworkers/CacheStorage.h

@@ -23,9 +23,8 @@ class CacheStorage final : public GarbageCollected<CacheStorage>, public ScriptW

public:

static CacheStorage* create(WebServiceWorkerCacheStorage*);

- ScriptPromise get(ScriptState*, const String& cacheName);

+ ScriptPromise open(ScriptState*, const String& cacheName);

ScriptPromise has(ScriptState*, const String& cacheName);

- ScriptPromise createFunction(ScriptState*, const String& cacheName);

ScriptPromise deleteFunction(ScriptState*, const String& cacheName);

ScriptPromise keys(ScriptState*);