Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 638013002: Apply automatic range checks to content enum types across IPC. (Closed)

Created:
6 years, 2 months ago by anujsharma
Modified:
6 years, 2 months ago
CC:
chromium-reviews, mkwst+moarreviews-ipc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Apply automatic range checks to content enum types across IPC. This is part of a long-running background task to remove the remaining uses of the unchecked IPC_ENUM_TRAITS() macro. BUG=246708 Committed: https://crrev.com/ef612ee574ecdff8d6d691f613cd6dac033db85c Cr-Commit-Position: refs/heads/master@{#298853}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/common/omnibox_focus_state.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/common/render_messages.h View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
anujsharma
nasko@chromium.org: Please review changes in for message change jochen@chromium.org: Please review changes in chrome/common module
6 years, 2 months ago (2014-10-08 14:50:55 UTC) #2
nasko
lgtm.
6 years, 2 months ago (2014-10-08 15:13:54 UTC) #5
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-09 11:22:04 UTC) #6
anujsharma
On 2014/10/09 11:22:04, jochen wrote: > lgtm Thanks nasko and jochen for lgtm.
6 years, 2 months ago (2014-10-09 11:23:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638013002/1
6 years, 2 months ago (2014-10-09 11:24:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 1925226d7a96173acd39952beccbb3bec9e57e9f
6 years, 2 months ago (2014-10-09 12:16:37 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 12:17:29 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef612ee574ecdff8d6d691f613cd6dac033db85c
Cr-Commit-Position: refs/heads/master@{#298853}

Powered by Google App Engine
This is Rietveld 408576698