Introduce WebFrameWidget to Blink

Source/web/WebLocalFrameImpl.cpp

Index: Source/web/WebLocalFrameImpl.cpp
diff --git a/Source/web/WebLocalFrameImpl.cpp b/Source/web/WebLocalFrameImpl.cpp
index b2dae77b5077f2e0d307ab164dbc75592ca34cdf..526c1a02eaec695da5658ea34a3484ab94c894c7 100644
--- a/Source/web/WebLocalFrameImpl.cpp
+++ b/Source/web/WebLocalFrameImpl.cpp
@@ -1552,6 +1552,7 @@ WebLocalFrameImpl* WebLocalFrameImpl::create(WebFrameClient* client)
 
 WebLocalFrameImpl::WebLocalFrameImpl(WebFrameClient* client)
     : m_frameLoaderClientImpl(this)
+    , m_frameWidget(0)
     , m_client(client)
     , m_autofillClient(0)
     , m_permissionClient(0)
@@ -2001,4 +2002,14 @@ void WebLocalFrameImpl::invalidateAll() const
     invalidateScrollbar();
 }
 
+void WebLocalFrameImpl::setFrameWidget(WebFrameWidgetImpl* frameWidget)

[dcheng, 2014/12/16 20:13:06]

Similar to my previous comment, I feel this should be folded into
WebLocalFrameImpl. At WebLocalFrameImpl creation, we should always know if we
need to create it with a widget or not. Instead of this setter, I'd prefer to
see two factory methods: WebLocalFrame::create() and
WebLocalFrame::createWithWidget(). This should avoid the need to check whether
or not frame widget is null for a local root.

[kenrb, 2014/12/16 22:04:12]

I think this makes RenderWidget too complicated, which really needs a WebWidget
to talk to.

[dcheng, 2014/12/16 23:20:20]

Do you have a Chromium patch that I could look at? If render widget doesn't hold
a pointer to a WebFrameWidget, can't it just hold a back pointer to the
RenderFrame it's in? It seems like it should be easy to get to the WebWidget
from there.

+{
+    m_frameWidget = frameWidget;
+}
+
+WebFrameWidgetImpl* WebLocalFrameImpl::frameWidget()
+{
+    return m_frameWidget;
+}
+
 } // namespace blink