Introduce WebFrameWidget to Blink

public/web/WebFrameWidget.h

 /*
- * Copyright (C) 2009 Google Inc. All rights reserved.
+ * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
  * copyright notice, this list of conditions and the following disclaimer
  * in the documentation and/or other materials provided with the
  * distribution.
  *     * Neither the name of Google Inc. nor the names of its
  * contributors may be used to endorse or promote products derived from
  * this software without specific prior written permission.
  *
  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
  * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
  * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef WebPopupMenu_h
-#define WebPopupMenu_h
+#ifndef WebFrameWidget_h
+#define WebFrameWidget_h
 
 #include "../platform/WebCommon.h"
-#include "WebWidget.h"
+#include "public/web/WebWidget.h"
 
 namespace blink {
 
+class Page;

[Nate Chapin, 2014/12/10 19:19:03]

Page shouldn't be forward declared in public/

[kenrb, 2014/12/11 20:21:22]

Done.

+class WebLocalFrame;
+class WebView;
 class WebWidgetClient;
 
-class WebPopupMenu : public WebWidget {
+class WebFrameWidget : public WebWidget {
 public:
-    BLINK_EXPORT static WebPopupMenu* create(WebWidgetClient*);
+    BLINK_EXPORT static WebFrameWidget* create(WebWidgetClient*, WebView*);
+
+    virtual void setLocalRoot(WebLocalFrame*) { }

[dcheng, 2014/12/10 21:00:59]

This is something we implement only inside Blink right? I think it's better to
make this pure virtual.

[kenrb, 2014/12/11 20:21:22]

I don't think that works. This header gets included by code in content, and they
need to see a vtable.

[dcheng, 2014/12/11 23:31:45]

Pure virtual is fine. WebFrame.h is composed of a lot of pure virtuals.

 };
 
 } // namespace blink
 
 #endif