Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 637953009: [Mojo] Remove mojo_view_manager_unittests from mojob (Closed)

Created:
6 years, 2 months ago by abarth-chromium
Modified:
6 years, 2 months ago
Reviewers:
viettrungluu
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), jamesr, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Mojo] Remove mojo_view_manager_unittests from mojob These tests currently crash. R=viettrungluu@chromium.org Committed: https://crrev.com/af0a41c82d4a7b01852d5036283c8a6fa3d8f32d Cr-Commit-Position: refs/heads/master@{#300328}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M mojo/tools/data/unittests View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
abarth-chromium
6 years, 2 months ago (2014-10-20 19:13:40 UTC) #1
viettrungluu
https://codereview.chromium.org/637953009/diff/1/mojo/tools/data/unittests File mojo/tools/data/unittests (left): https://codereview.chromium.org/637953009/diff/1/mojo/tools/data/unittests#oldcode19 mojo/tools/data/unittests:19: mojo_view_manager_unittests Maybe you should comment it out to disable ...
6 years, 2 months ago (2014-10-20 19:20:55 UTC) #2
abarth-chromium
https://codereview.chromium.org/637953009/diff/1/mojo/tools/data/unittests File mojo/tools/data/unittests (left): https://codereview.chromium.org/637953009/diff/1/mojo/tools/data/unittests#oldcode19 mojo/tools/data/unittests:19: mojo_view_manager_unittests On 2014/10/20 at 19:20:55, viettrungluu wrote: > Maybe ...
6 years, 2 months ago (2014-10-20 19:36:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637953009/20001
6 years, 2 months ago (2014-10-20 19:38:33 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-20 20:51:14 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 20:52:06 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/af0a41c82d4a7b01852d5036283c8a6fa3d8f32d
Cr-Commit-Position: refs/heads/master@{#300328}

Powered by Google App Engine
This is Rietveld 408576698