content/browser/media/media_internals.cc - Issue 637953008: Improve video capture columns in chrome://media-internals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/media_internals.cc

Issue 637953008: Improve video capture columns in chrome://media-internals (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move to impl, update comments, remove pixel format Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/media/media_internals.cc

diff --git a/content/browser/media/media_internals.cc b/content/browser/media/media_internals.cc

index 3813e24fc623e8e3cde1386e3c7bc4e4d70b719f..28afab3da3acbad7dbd7154940d3562709dbedf8 100644

--- a/content/browser/media/media_internals.cc

+++ b/content/browser/media/media_internals.cc

@@ -246,9 +246,9 @@ void MediaInternals::UpdateVideoCaptureDeviceCapabilities(

"name", video_capture_device_info.name.GetNameAndModel());

device_dict->Set("formats", format_list);

#if defined(OS_WIN) || defined(OS_MACOSX)

- device_dict->SetInteger(

+ device_dict->SetString(

"captureApi",

- video_capture_device_info.name.capture_api_type());

+ video_capture_device_info.name.GetCaptureApiTypeString());

#endif

video_capture_capabilities_cached_data_.Append(device_dict);

}

« no previous file with comments | « no previous file | content/browser/media/media_internals_unittest.cc » ('j') | content/browser/media/media_internals_unittest.cc » ('J')