Improve video capture columns in chrome://media-internals

media/video/capture/video_capture_device.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // VideoCaptureDevice is the abstract base class for realizing video capture
 // device support in Chromium. It provides the interface for OS dependent
 // implementations.
 // The class is created and functions are invoked on a thread owned by
 // VideoCaptureManager. Capturing is done on other threads, depending on the OS
 // specific implementation.
@@ skipping 90 matching lines @@
     bool operator<(const Name& other) const {
       return unique_id_ < other.id();
     }
 
 #if defined(OS_WIN) || defined(OS_MACOSX)
     CaptureApiType capture_api_type() const {
       return capture_api_class_.capture_api_type();
     }
 #endif
 #if defined(OS_WIN)
+    const std::string capture_api_type_string() const {

[tommi (sloooow) - chröme, 2014/10/20 22:09:42]

nit: these methods might as well just return const char* since it's always a
static string that's being returned and there's no need to create a new
std::string from it.

Also, would like for the implementation to live in the cc file.

[burnik, 2014/10/21 11:27:04]

Done.

+      switch(capture_api_type()) {
+        case MEDIA_FOUNDATION:
+          return "MEDIA_FOUNDATION";
+        case DIRECT_SHOW:
+          return "DIRECT_SHOW";
+        case DIRECT_SHOW_WDM_CROSSBAR:
+          return "DIRECT_SHOW_WDM_CROSSBAR";
+        default:
+          NOTREACHED() << "Unknown Video Capture API type!";
+          return "API_TYPE_UNKNOWN";
+      }
+    }
     // Certain devices need an ID different from the |unique_id_| for
     // capabilities retrieval.
     const std::string& capabilities_id() const {
       return capabilities_id_;
     }
     void set_capabilities_id(const std::string& id) {
       capabilities_id_ = id;
     }
 #endif
 #if defined(OS_MACOSX)
+    const std::string capture_api_type_string() const {
+      switch(capture_api_type()) {
+        case AVFOUNDATION:
+          return "AVFOUNDATION";
+        case QTKIT:
+          return "QTKIT";
+        case DECKLINK:
+          return "DECKLINK";
+        default:
+          NOTREACHED() << "Unknown Video Capture API type!";
+          return "API_TYPE_UNKNOWN";
+      }
+    }
     TransportType transport_type() const {
       return transport_type_;
     }
     bool is_blacklisted() const {
       return is_blacklisted_;
     }
     void set_is_blacklisted(bool is_blacklisted) {
       is_blacklisted_ = is_blacklisted;
     }
 #endif  // if defined(OS_WIN)
@@ skipping 189 matching lines @@
   virtual void CaptureImage() {}
 
  protected:
   static const int kPowerLine50Hz = 50;
   static const int kPowerLine60Hz = 60;
 };
 
 }  // namespace media
 
 #endif  // MEDIA_VIDEO_CAPTURE_VIDEO_CAPTURE_DEVICE_H_