Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 637953005: Remove references to linux_asan from PRESUBMIT files. (Closed)

Created:
6 years, 2 months ago by Paweł Hajdan Jr.
Modified:
6 years, 2 months ago
Reviewers:
earthdok
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 7

Patch Set 2 : fixes #

Patch Set 3 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M PRESUBMIT.py View 1 chunk +0 lines, -1 line 0 comments Download
M PRESUBMIT_test.py View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M tools/lsan/PRESUBMIT.py View 1 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
Paweł Hajdan Jr.
6 years, 2 months ago (2014-10-20 11:48:22 UTC) #2
earthdok
https://codereview.chromium.org/637953005/diff/1/PRESUBMIT_test.py File PRESUBMIT_test.py (left): https://codereview.chromium.org/637953005/diff/1/PRESUBMIT_test.py#oldcode783 PRESUBMIT_test.py:783: 'linux_browser_asan', Isn't this going away too? https://codereview.chromium.org/637953005/diff/1/tools/lsan/PRESUBMIT.py File tools/lsan/PRESUBMIT.py ...
6 years, 2 months ago (2014-10-20 11:57:54 UTC) #3
earthdok
https://codereview.chromium.org/637953005/diff/1/tools/lsan/PRESUBMIT.py File tools/lsan/PRESUBMIT.py (right): https://codereview.chromium.org/637953005/diff/1/tools/lsan/PRESUBMIT.py#newcode41 tools/lsan/PRESUBMIT.py:41: 'mac_asan': set(['compile']), (same)
6 years, 2 months ago (2014-10-20 11:58:42 UTC) #4
Paweł Hajdan Jr.
https://codereview.chromium.org/637953005/diff/1/tools/lsan/PRESUBMIT.py File tools/lsan/PRESUBMIT.py (right): https://codereview.chromium.org/637953005/diff/1/tools/lsan/PRESUBMIT.py#newcode38 tools/lsan/PRESUBMIT.py:38: 'linux_chromium_asan_rel': set(['compile']), On 2014/10/20 11:57:53, earthdok wrote: > There's ...
6 years, 2 months ago (2014-10-20 15:03:56 UTC) #5
earthdok
https://codereview.chromium.org/637953005/diff/1/PRESUBMIT_test.py File PRESUBMIT_test.py (left): https://codereview.chromium.org/637953005/diff/1/PRESUBMIT_test.py#oldcode783 PRESUBMIT_test.py:783: 'linux_browser_asan', On 2014/10/20 11:57:53, earthdok wrote: > Isn't this ...
6 years, 2 months ago (2014-10-20 15:32:18 UTC) #6
Paweł Hajdan Jr.
https://codereview.chromium.org/637953005/diff/1/PRESUBMIT_test.py File PRESUBMIT_test.py (left): https://codereview.chromium.org/637953005/diff/1/PRESUBMIT_test.py#oldcode783 PRESUBMIT_test.py:783: 'linux_browser_asan', On 2014/10/20 11:57:53, earthdok wrote: > Isn't this ...
6 years, 2 months ago (2014-10-21 07:58:04 UTC) #7
earthdok
lgtm
6 years, 2 months ago (2014-10-21 11:32:28 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/c793742b02142aed967568c48def709d6d16bd38 Cr-Commit-Position: refs/heads/master@{#300468}
6 years, 2 months ago (2014-10-21 12:06:41 UTC) #9
Paweł Hajdan Jr.
6 years, 2 months ago (2014-10-21 12:06:45 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
c793742b02142aed967568c48def709d6d16bd38 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698