Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 637933004: Fix memory issues in compositor_unittests (Closed)

Created:
6 years, 2 months ago by enne (OOO)
Modified:
6 years, 2 months ago
Reviewers:
danakj, piman
CC:
cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, earthdok, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, sievers+watch_chromium.org, Ian Vollick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix memory issues in compositor_unittests These LayerDelegates are trying to paint rectangles at offsets, but end up always painting their rectangles at the layer origin. This causes any scheduled paint not at the origin to not fill the entire invalidation, leading to uninitialized pixels being drawn. The fix is rather than drawing a rect at the origin, just fill the entire clip with the right color. The clip is in the right place, so this will do what the test intends. Also fill the canvas in the DrawTreeLayerDelegate, which was always leaving it uninitialized. R=piman@chromium.org,danakj@chromium.org BUG=421107 Committed: https://crrev.com/9b779de87d09341bb31eca53c8097a0f37f97c2d Cr-Commit-Position: refs/heads/master@{#298817}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/compositor/layer_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
enne (OOO)
6 years, 2 months ago (2014-10-08 22:17:55 UTC) #1
piman
LGTM, thanks!
6 years, 2 months ago (2014-10-08 22:20:29 UTC) #2
danakj
LGTM 2
6 years, 2 months ago (2014-10-08 22:20:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637933004/1
6 years, 2 months ago (2014-10-08 22:29:32 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-09 02:54:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637933004/1
6 years, 2 months ago (2014-10-09 06:17:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 33d3a1d49becb002ca38bf73649e2c7dee767f76
6 years, 2 months ago (2014-10-09 06:26:44 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 06:27:59 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b779de87d09341bb31eca53c8097a0f37f97c2d
Cr-Commit-Position: refs/heads/master@{#298817}

Powered by Google App Engine
This is Rietveld 408576698