src/x64/lithium-codegen-x64.cc - Issue 637923004: Never call MacroAssembler::Allocate() with incorrect size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-codegen-x64.cc

Issue 637923004: Never call MacroAssembler::Allocate() with incorrect size. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Test updated Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/lithium-codegen-x64.cc

diff --git a/src/x64/lithium-codegen-x64.cc b/src/x64/lithium-codegen-x64.cc

index 1981d55f7950409248ea0dd4c9e01fc7326d4ff7..23a116d20a84779b0eaf7ac1867ecd27dcf2bd61 100644

--- a/src/x64/lithium-codegen-x64.cc

+++ b/src/x64/lithium-codegen-x64.cc

@@ -5332,7 +5332,8 @@ void LCodeGen::DoAllocate(LAllocate* instr) {

if (instr->size()->IsConstantOperand()) {

int32_t size = ToInteger32(LConstantOperand::cast(instr->size()));

- if (size <= Page::kMaxRegularHeapObjectSize) {

+ if (static_cast<uint32_t>(size) <=

+ static_cast<uint32_t>(Page::kMaxRegularHeapObjectSize)) {

__ Allocate(size, result, temp, no_reg, deferred->entry(), flags);

} else {

__ jmp(deferred->entry());

« no previous file with comments | « src/mips64/lithium-codegen-mips64.cc ('k') | src/x87/lithium-codegen-x87.cc » ('j') | no next file with comments »