Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: src/mips/lithium-codegen-mips.cc

Issue 637923004: Never call MacroAssembler::Allocate() with incorrect size. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Test updated Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/mips64/lithium-codegen-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved.7 1 // Copyright 2012 the V8 project authors. All rights reserved.7
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5315 matching lines...) Expand 10 before | Expand all | Expand 10 after
5326 if (instr->hydrogen()->IsOldPointerSpaceAllocation()) { 5326 if (instr->hydrogen()->IsOldPointerSpaceAllocation()) {
5327 DCHECK(!instr->hydrogen()->IsOldDataSpaceAllocation()); 5327 DCHECK(!instr->hydrogen()->IsOldDataSpaceAllocation());
5328 DCHECK(!instr->hydrogen()->IsNewSpaceAllocation()); 5328 DCHECK(!instr->hydrogen()->IsNewSpaceAllocation());
5329 flags = static_cast<AllocationFlags>(flags | PRETENURE_OLD_POINTER_SPACE); 5329 flags = static_cast<AllocationFlags>(flags | PRETENURE_OLD_POINTER_SPACE);
5330 } else if (instr->hydrogen()->IsOldDataSpaceAllocation()) { 5330 } else if (instr->hydrogen()->IsOldDataSpaceAllocation()) {
5331 DCHECK(!instr->hydrogen()->IsNewSpaceAllocation()); 5331 DCHECK(!instr->hydrogen()->IsNewSpaceAllocation());
5332 flags = static_cast<AllocationFlags>(flags | PRETENURE_OLD_DATA_SPACE); 5332 flags = static_cast<AllocationFlags>(flags | PRETENURE_OLD_DATA_SPACE);
5333 } 5333 }
5334 if (instr->size()->IsConstantOperand()) { 5334 if (instr->size()->IsConstantOperand()) {
5335 int32_t size = ToInteger32(LConstantOperand::cast(instr->size())); 5335 int32_t size = ToInteger32(LConstantOperand::cast(instr->size()));
5336 if (size <= Page::kMaxRegularHeapObjectSize) { 5336 if (static_cast<uint32_t>(size) <=
5337 static_cast<uint32_t>(Page::kMaxRegularHeapObjectSize)) {
5337 __ Allocate(size, result, scratch, scratch2, deferred->entry(), flags); 5338 __ Allocate(size, result, scratch, scratch2, deferred->entry(), flags);
5338 } else { 5339 } else {
5339 __ jmp(deferred->entry()); 5340 __ jmp(deferred->entry());
5340 } 5341 }
5341 } else { 5342 } else {
5342 Register size = ToRegister(instr->size()); 5343 Register size = ToRegister(instr->size());
5343 __ Allocate(size, result, scratch, scratch2, deferred->entry(), flags); 5344 __ Allocate(size, result, scratch, scratch2, deferred->entry(), flags);
5344 } 5345 }
5345 5346
5346 __ bind(deferred->exit()); 5347 __ bind(deferred->exit());
(...skipping 577 matching lines...) Expand 10 before | Expand all | Expand 10 after
5924 __ li(at, scope_info); 5925 __ li(at, scope_info);
5925 __ Push(at, ToRegister(instr->function())); 5926 __ Push(at, ToRegister(instr->function()));
5926 CallRuntime(Runtime::kPushBlockContext, 2, instr); 5927 CallRuntime(Runtime::kPushBlockContext, 2, instr);
5927 RecordSafepoint(Safepoint::kNoLazyDeopt); 5928 RecordSafepoint(Safepoint::kNoLazyDeopt);
5928 } 5929 }
5929 5930
5930 5931
5931 #undef __ 5932 #undef __
5932 5933
5933 } } // namespace v8::internal 5934 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/mips64/lithium-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698