Source/web/ChromeClientImpl.cpp - Issue 637873006: Add a flag to show if the FileChooserCompletion needs local paths or not.

Unified Diff: Source/web/ChromeClientImpl.cpp

Issue 637873006: Add a flag to show if the FileChooserCompletion needs local paths or not. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/ChromeClientImpl.cpp

diff --git a/Source/web/ChromeClientImpl.cpp b/Source/web/ChromeClientImpl.cpp

index 6017435c6e38b4754c6e11d72c9ce4e091c77742..de8d7837d877e203a775e91b34edb3b4f2323432 100644

--- a/Source/web/ChromeClientImpl.cpp

+++ b/Source/web/ChromeClientImpl.cpp

@@ -614,6 +614,7 @@ void ChromeClientImpl::runOpenPanel(LocalFrame* frame, PassRefPtr<FileChooser> f

if (params.selectedFiles.size() > 0)

params.initialValue = params.selectedFiles[0];

params.useMediaCapture = fileChooser->settings().useMediaCapture;

+ params.needLocalPath = fileChooser->settings().allowsDirectoryUpload;

tkent 2014/10/16 00:39:02 I think we need a local path even if directory upl

hirono 2014/10/16 06:45:07 Currently I'm adding the support to upload files w

tkent 2014/10/16 07:50:30 Do you implement it for WebFileChooserCompletinoIm

hirono 2014/10/16 07:52:45 Yes, this is a draft patch. https://codereview.chr

tkent 2014/10/16 07:59:52 ok, I understand.

WebFileChooserCompletionImpl* chooserCompletion =

new WebFileChooserCompletionImpl(fileChooser);

« no previous file with comments | « no previous file | public/web/WebFileChooserParams.h » ('j') | public/web/WebFileChooserParams.h » ('J')