Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Side by Side Diff: Source/web/ChromeClientImpl.cpp

Issue 637873006: Add a flag to show if the FileChooserCompletion needs local paths or not. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | public/web/WebFileChooserParams.h » ('j') | public/web/WebFileChooserParams.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 596 matching lines...) Expand 10 before | Expand all | Expand 10 after
607 return; 607 return;
608 608
609 WebFileChooserParams params; 609 WebFileChooserParams params;
610 params.multiSelect = fileChooser->settings().allowsMultipleFiles; 610 params.multiSelect = fileChooser->settings().allowsMultipleFiles;
611 params.directory = fileChooser->settings().allowsDirectoryUpload; 611 params.directory = fileChooser->settings().allowsDirectoryUpload;
612 params.acceptTypes = fileChooser->settings().acceptTypes(); 612 params.acceptTypes = fileChooser->settings().acceptTypes();
613 params.selectedFiles = fileChooser->settings().selectedFiles; 613 params.selectedFiles = fileChooser->settings().selectedFiles;
614 if (params.selectedFiles.size() > 0) 614 if (params.selectedFiles.size() > 0)
615 params.initialValue = params.selectedFiles[0]; 615 params.initialValue = params.selectedFiles[0];
616 params.useMediaCapture = fileChooser->settings().useMediaCapture; 616 params.useMediaCapture = fileChooser->settings().useMediaCapture;
617 params.needLocalPath = fileChooser->settings().allowsDirectoryUpload;
tkent 2014/10/16 00:39:02 I think we need a local path even if directory upl
hirono 2014/10/16 06:45:07 Currently I'm adding the support to upload files w
tkent 2014/10/16 07:50:30 Do you implement it for WebFileChooserCompletinoIm
hirono 2014/10/16 07:52:45 Yes, this is a draft patch. https://codereview.chr
tkent 2014/10/16 07:59:52 ok, I understand.
617 618
618 WebFileChooserCompletionImpl* chooserCompletion = 619 WebFileChooserCompletionImpl* chooserCompletion =
619 new WebFileChooserCompletionImpl(fileChooser); 620 new WebFileChooserCompletionImpl(fileChooser);
620 621
621 if (client->runFileChooser(params, chooserCompletion)) 622 if (client->runFileChooser(params, chooserCompletion))
622 return; 623 return;
623 624
624 // Choosing failed, so do callback with an empty list. 625 // Choosing failed, so do callback with an empty list.
625 chooserCompletion->didChooseFile(WebVector<WebString>()); 626 chooserCompletion->didChooseFile(WebVector<WebString>());
626 } 627 }
(...skipping 256 matching lines...) Expand 10 before | Expand all | Expand 10 after
883 m_webView->autofillClient()->textFieldDidEndEditing(WebInputElement(&inp utElement)); 884 m_webView->autofillClient()->textFieldDidEndEditing(WebInputElement(&inp utElement));
884 } 885 }
885 886
886 void ChromeClientImpl::openTextDataListChooser(HTMLInputElement& input) 887 void ChromeClientImpl::openTextDataListChooser(HTMLInputElement& input)
887 { 888 {
888 if (m_webView->autofillClient()) 889 if (m_webView->autofillClient())
889 m_webView->autofillClient()->openTextDataListChooser(WebInputElement(&in put)); 890 m_webView->autofillClient()->openTextDataListChooser(WebInputElement(&in put));
890 } 891 }
891 892
892 } // namespace blink 893 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | public/web/WebFileChooserParams.h » ('j') | public/web/WebFileChooserParams.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698