[DOCS] Edit references to Chrome 31 and earlier.

[DOCS] Edit references to Chrome 31 and earlier.

BUG=none
R=
TEST=none
NOTRY=true
(documentation only change)

Committed: https://crrev.com/a7749732ab1cb379dde93c32d0786914f7af0e19
Cr-Commit-Position: refs/heads/master@{#302801}

[jpmedley, 2014-10-08 16:44:11]

jmedley@chromium.org changed reviewers:
+ binji@chromium.org, jfb@chromium.org

[Sam Clegg, 2014-10-08 17:38:01]

sbc@chromium.org changed reviewers:
+ sbc@chromium.org

[Sam Clegg, 2014-10-08 17:38:01]

https://codereview.chromium.org/637873003/diff/1/native_client_sdk/src/doc/de...
File native_client_sdk/src/doc/devguide/tutorial/tutorial-part1.rst (right):

https://codereview.chromium.org/637873003/diff/1/native_client_sdk/src/doc/de...
native_client_sdk/src/doc/devguide/tutorial/tutorial-part1.rst:93: PNaCl is
enabled by default in Chrome. You must use a version of Chrome that's
I wouldn't say this is a must.  How about "it is recommended that you use".

https://codereview.chromium.org/637873003/diff/1/native_client_sdk/src/doc/na...
File native_client_sdk/src/doc/nacl-and-pnacl.rst (right):

https://codereview.chromium.org/637873003/diff/1/native_client_sdk/src/doc/na...
native_client_sdk/src/doc/nacl-and-pnacl.rst:84: Chrome supports translation of
pexe  modules and their use in web applications
extra space?

https://codereview.chromium.org/637873003/diff/1/native_client_sdk/src/doc/sd...
File native_client_sdk/src/doc/sdk/examples.rst (left):

https://codereview.chromium.org/637873003/diff/1/native_client_sdk/src/doc/sd...
native_client_sdk/src/doc/sdk/examples.rst:38: 
I wonder its worth keeping this information around since its still needed if you
want to run NaCl (rather than PNaCl)?

How about the opening paragraph says something like this:  "If you are targeting
Portable Native Client you can skip this section.  If you want to run Native
Client outside of the chrome web store you much specifically enable Native
Client in Chrome:"

[JF, 2014-10-08 22:00:37]

https://codereview.chromium.org/637873003/diff/1/native_client_sdk/src/doc/de...
File native_client_sdk/src/doc/devguide/devcycle/running.rst (right):

https://codereview.chromium.org/637873003/diff/1/native_client_sdk/src/doc/de...
native_client_sdk/src/doc/devguide/devcycle/running.rst:150: the application in
Chrome 37 or higher. To check which version of Chrome you're
Should we make this some form of a macro that translates to the latest version
at rst generation time? We can probably sync this with the release notes?

https://codereview.chromium.org/637873003/diff/1/native_client_sdk/src/doc/de...
File native_client_sdk/src/doc/devguide/tutorial/tutorial-part1.rst (right):

https://codereview.chromium.org/637873003/diff/1/native_client_sdk/src/doc/de...
native_client_sdk/src/doc/devguide/tutorial/tutorial-part1.rst:93: PNaCl is
enabled by default in Chrome. You must use a version of Chrome that's
On 2014/10/08 17:38:01, Sam Clegg wrote:
> I wouldn't say this is a must.  How about "it is recommended that you use".

We could explain why it's recommended: older pexes will always work, but newer
pexes won't if they use APIs that were added to an SDK version newer than the
Chrome version used.

https://codereview.chromium.org/637873003/diff/1/native_client_sdk/src/doc/fa...
File native_client_sdk/src/doc/faq.rst (right):

https://codereview.chromium.org/637873003/diff/1/native_client_sdk/src/doc/fa...
native_client_sdk/src/doc/faq.rst:516: Client. Please `upgrade now
<http://www.google.com/chrome/>`_ if you are
Should we point out that the Chrome version can be obtained with
``about:chrome``?

https://codereview.chromium.org/637873003/diff/1/native_client_sdk/src/doc/fa...
native_client_sdk/src/doc/faq.rst:520: SDK versions had experimental support for
PNaCl, now deprecated). :ref:`Update
Can we drop the parenthesized sentence here? If we don't ship SDKs older than
pepper_31 then it's a non-issue.

https://codereview.chromium.org/637873003/diff/1/native_client_sdk/src/doc/fa...
native_client_sdk/src/doc/faq.rst:522: Chrome that matches.
That matches the SDK version?

[native-client-reviews_googlegroups.com, 2014-10-08 23:21:03]

On Wed, Oct 8, 2014 at 4:00 PM, <jfb@chromium.org> wrote:

> Should we make this some form of a macro that translates to the latest
> version at rst generation time? We can probably sync this with the
> release notes?
>

It's been in my head. But I've had no time to implement.

Joe Medley | Technical Writer | jmedley@google.com | 816-678-7195

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.

[chromium-reviews, 2014-10-08 23:21:16]

On Wed, Oct 8, 2014 at 4:00 PM, <jfb@chromium.org> wrote:

> Should we make this some form of a macro that translates to the latest
> version at rst generation time? We can probably sync this with the
> release notes?
>

It's been in my head. But I've had no time to implement.

Joe Medley | Technical Writer | jmedley@google.com | 816-678-7195

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jpmedley, 2014-11-05 03:56:11]

PTAL

https://codereview.chromium.org/637873003/diff/1/native_client_sdk/src/doc/de...
File native_client_sdk/src/doc/devguide/tutorial/tutorial-part1.rst (right):

https://codereview.chromium.org/637873003/diff/1/native_client_sdk/src/doc/de...
native_client_sdk/src/doc/devguide/tutorial/tutorial-part1.rst:93: PNaCl is
enabled by default in Chrome. You must use a version of Chrome that's
On 2014/10/08 17:38:01, Sam Clegg wrote:
> I wouldn't say this is a must.  How about "it is recommended that you use".

Done.

https://codereview.chromium.org/637873003/diff/1/native_client_sdk/src/doc/de...
native_client_sdk/src/doc/devguide/tutorial/tutorial-part1.rst:93: PNaCl is
enabled by default in Chrome. You must use a version of Chrome that's
On 2014/10/08 22:00:37, JF wrote:
> On 2014/10/08 17:38:01, Sam Clegg wrote:
> > I wouldn't say this is a must.  How about "it is recommended that you use".
> 
> We could explain why it's recommended: older pexes will always work, but newer
> pexes won't if they use APIs that were added to an SDK version newer than the
> Chrome version used.

Done.

https://codereview.chromium.org/637873003/diff/1/native_client_sdk/src/doc/de...
native_client_sdk/src/doc/devguide/tutorial/tutorial-part1.rst:93: PNaCl is
enabled by default in Chrome. You must use a version of Chrome that's
On 2014/10/08 22:00:37, JF wrote:
> On 2014/10/08 17:38:01, Sam Clegg wrote:
> > I wouldn't say this is a must.  How about "it is recommended that you use".
> 
> We could explain why it's recommended: older pexes will always work, but newer
> pexes won't if they use APIs that were added to an SDK version newer than the
> Chrome version used.

Done.

https://codereview.chromium.org/637873003/diff/1/native_client_sdk/src/doc/fa...
File native_client_sdk/src/doc/faq.rst (right):

https://codereview.chromium.org/637873003/diff/1/native_client_sdk/src/doc/fa...
native_client_sdk/src/doc/faq.rst:516: Client. Please `upgrade now
<http://www.google.com/chrome/>`_ if you are
On 2014/10/08 22:00:37, JF wrote:
> Should we point out that the Chrome version can be obtained with
> ``about:chrome``?

Done.

https://codereview.chromium.org/637873003/diff/1/native_client_sdk/src/doc/fa...
native_client_sdk/src/doc/faq.rst:520: SDK versions had experimental support for
PNaCl, now deprecated). :ref:`Update
On 2014/10/08 22:00:37, JF wrote:
> Can we drop the parenthesized sentence here? If we don't ship SDKs older than
> pepper_31 then it's a non-issue.

Done.

https://codereview.chromium.org/637873003/diff/1/native_client_sdk/src/doc/fa...
native_client_sdk/src/doc/faq.rst:522: Chrome that matches.
On 2014/10/08 22:00:37, JF wrote:
> That matches the SDK version?

Done.

https://codereview.chromium.org/637873003/diff/1/native_client_sdk/src/doc/na...
File native_client_sdk/src/doc/nacl-and-pnacl.rst (right):

https://codereview.chromium.org/637873003/diff/1/native_client_sdk/src/doc/na...
native_client_sdk/src/doc/nacl-and-pnacl.rst:84: Chrome supports translation of
pexe  modules and their use in web applications
On 2014/10/08 17:38:01, Sam Clegg wrote:
> extra space?

Done.

[JF, 2014-11-05 14:41:22]

lgtm

https://codereview.chromium.org/637873003/diff/20001/native_client_sdk/src/do...
File native_client_sdk/src/doc/devguide/tutorial/tutorial-part1.rst (right):

https://codereview.chromium.org/637873003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/devguide/tutorial/tutorial-part1.rst:96: the converse
is not.
"the converse is not true"?

[jpmedley, 2014-11-05 15:17:42]

The CQ bit was checked by jmedley@chromium.org

[commit-bot: I haz the power, 2014-11-05 15:18:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/637873003/40001

[commit-bot: I haz the power, 2014-11-05 15:20:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-11-05 15:20:50]

Patchset 3 (id:??) landed as
https://crrev.com/a7749732ab1cb379dde93c32d0786914f7af0e19
Cr-Commit-Position: refs/heads/master@{#302801}