The empty husk of a JSFunction is useful to us.

The empty husk of a JSFunction is useful to us.

We hollow out the rotting core and with evil intent repurpose its dry carcass to empower ourselves; with such a shell we can test.

R=mstarzinger@chromium.org

BUG=

Committed: https://code.google.com/p/v8/source/detail?r=24459

[Michael Starzinger, 2014-10-08 09:08:11]

LGTM.

https://codereview.chromium.org/637873002/diff/1/test/cctest/compiler/functio...
File test/cctest/compiler/function-tester.h (right):

https://codereview.chromium.org/637873002/diff/1/test/cctest/compiler/functio...
test/cctest/compiler/function-tester.h:43:
function(NewFunction("(function(a,b){'use strict'; return 0;})")),
nit: Just use the empty function ... it looks confusing to have code inside when
it doesn't matter at all.

https://codereview.chromium.org/637873002/diff/1/test/cctest/compiler/functio...
test/cctest/compiler/function-tester.h:152: // foo me
nit: Hmm, it looks foo'ed already. :)

[titzer, 2014-10-08 09:22:55]

https://codereview.chromium.org/637873002/diff/1/test/cctest/compiler/functio...
File test/cctest/compiler/function-tester.h (right):

https://codereview.chromium.org/637873002/diff/1/test/cctest/compiler/functio...
test/cctest/compiler/function-tester.h:43:
function(NewFunction("(function(a,b){'use strict'; return 0;})")),
On 2014/10/08 09:08:10, Michael Starzinger wrote:
> nit: Just use the empty function ... it looks confusing to have code inside
when
> it doesn't matter at all.

Done.

https://codereview.chromium.org/637873002/diff/1/test/cctest/compiler/functio...
test/cctest/compiler/function-tester.h:152: // foo me
On 2014/10/08 09:08:10, Michael Starzinger wrote:
> nit: Hmm, it looks foo'ed already. :)

Done.

[titzer, 2014-10-08 09:23:44]

Committed patchset #1 manually as 24459 (presubmit successful).