Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 637863006: DevTools: update remote discovery page, render both title and url for items. (Closed)

Created:
6 years, 2 months ago by pfeldman
Modified:
6 years, 2 months ago
Reviewers:
dgozman
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

DevTools: update remote discovery page, render both title and url for items. NOTRY=true BUG=425600 Committed: https://crrev.com/ffd712486c4ae7d71acf664b4d41391e214beed6 Cr-Commit-Position: refs/heads/master@{#300649}

Patch Set 1 #

Total comments: 4

Patch Set 2 : for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -63 lines) Patch
M chrome/browser/devtools/frontend/devtools_discovery_page.html View 1 2 chunks +67 lines, -63 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
pfeldman
6 years, 2 months ago (2014-10-21 17:23:49 UTC) #2
dgozman
lgtm https://codereview.chromium.org/637863006/diff/1/chrome/browser/devtools/frontend/devtools_discovery_page.html File chrome/browser/devtools/frontend/devtools_discovery_page.html (right): https://codereview.chromium.org/637863006/diff/1/chrome/browser/devtools/frontend/devtools_discovery_page.html#newcode129 chrome/browser/devtools/frontend/devtools_discovery_page.html:129: item_object.thumbnailUrl + while you are here, update the ...
6 years, 2 months ago (2014-10-21 18:45:13 UTC) #3
pfeldman
https://codereview.chromium.org/637863006/diff/1/chrome/browser/devtools/frontend/devtools_discovery_page.html File chrome/browser/devtools/frontend/devtools_discovery_page.html (right): https://codereview.chromium.org/637863006/diff/1/chrome/browser/devtools/frontend/devtools_discovery_page.html#newcode129 chrome/browser/devtools/frontend/devtools_discovery_page.html:129: item_object.thumbnailUrl + On 2014/10/21 18:45:13, dgozman wrote: > while ...
6 years, 2 months ago (2014-10-22 08:26:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637863006/20001
6 years, 2 months ago (2014-10-22 08:35:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-22 08:35:50 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 08:36:39 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ffd712486c4ae7d71acf664b4d41391e214beed6
Cr-Commit-Position: refs/heads/master@{#300649}

Powered by Google App Engine
This is Rietveld 408576698