Better handling of goma inside chroot environment.

Better handling of goma inside chroot environment.

/tmp is shared between inside and outside of chroot.  It confuses
goma client.  To avoid such a confusion, make goma use different
temporary directory from external world.

BUG=409482
Committed: https://crrev.com/53d0973ee890273cd78fd657556907dc0a91d2dc
Cr-Commit-Position: refs/heads/master@{#298822}

[Yoshisato Yanagisawa, 2014-10-08 09:02:53]

yyanagisawa@chromium.org changed reviewers:
+ thestig@chromium.org

[Yoshisato Yanagisawa, 2014-10-08 09:02:53]

Hi,

this is a change for better handling of goma inside chroot.  To avoid goma's
confusion, it is better to separate a temporary directory.

Will you review the code?

[Lei Zhang, 2014-10-08 19:00:22]

lgtm with everything quoted.

https://codereview.chromium.org/637863002/diff/1/build/install-chroot.sh
File build/install-chroot.sh (right):

https://codereview.chromium.org/637863002/diff/1/build/install-chroot.sh#newc...
build/install-chroot.sh:508: export
GOMA_TMP_DIR=/tmp/goma_tmp_$CHROOT_SESSION_ID
Please put variables in quotes. "/tmp/goma_tmp_$CHROOT_SESSION_ID"

Ditto below with $GOMA_TMP_DIR.

[Yoshisato Yanagisawa, 2014-10-09 01:02:55]

Thanks for the review.

https://codereview.chromium.org/637863002/diff/1/build/install-chroot.sh
File build/install-chroot.sh (right):

https://codereview.chromium.org/637863002/diff/1/build/install-chroot.sh#newc...
build/install-chroot.sh:508: export
GOMA_TMP_DIR=/tmp/goma_tmp_$CHROOT_SESSION_ID
On 2014/10/08 19:00:22, Lei Zhang wrote:
> Please put variables in quotes. "/tmp/goma_tmp_$CHROOT_SESSION_ID"
> 
> Ditto below with $GOMA_TMP_DIR.

Done.

[Yoshisato Yanagisawa, 2014-10-09 01:48:02]

The CQ bit was checked by yyanagisawa@chromium.org

[commit-bot: I haz the power, 2014-10-09 01:53:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/637863002/20001

[commit-bot: I haz the power, 2014-10-09 04:00:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-09 04:00:56]

Exceeded time limit waiting for builds to trigger.

[Yoshisato Yanagisawa, 2014-10-09 07:16:08]

The CQ bit was checked by yyanagisawa@chromium.org

[commit-bot: I haz the power, 2014-10-09 07:16:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/637863002/20001

[commit-bot: I haz the power, 2014-10-09 07:18:21]

Committed patchset #2 (id:20001) as 8c1716a0463832511f5e9c02747ac547f8f14b9e

[commit-bot: I haz the power, 2014-10-09 07:19:44]

Patchset 2 (id:??) landed as
https://crrev.com/53d0973ee890273cd78fd657556907dc0a91d2dc
Cr-Commit-Position: refs/heads/master@{#298822}