Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 637733002: Instrumenting read callbacks to find jank in TCPSocketWin::Core::ReadDelegate::OnObjectSignaled (Closed)

Created:
6 years, 2 months ago by vadimt
Modified:
6 years, 2 months ago
Reviewers:
agl
CC:
chromium-reviews, cbentzel+watch_chromium.org, Alexei Svitkine (slow), asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Instrumenting read callbacks to find jank in TCPSocketWin::Core::ReadDelegate::OnObjectSignaled. See the bug. I was told that one of the pieces of code that could cause jank is the callback invoked in IO thread once the read on a socket is complete. I'm not familiar with the code, and I instrumented places that look relevant; feel free to suggest adding or removing the instrumentation. BUG=418183 TBR=asanka@chromium.org Committed: https://crrev.com/06b0b7030916fd66381d0c547c5916c1d0934161 Cr-Commit-Position: refs/heads/master@{#299176}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M net/socket/ssl_client_socket_nss.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M net/socket/tcp_client_socket.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M net/socket/tcp_socket_win.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
vadimt
asanka@, please provide OWNER's approval
6 years, 2 months ago (2014-10-08 01:29:23 UTC) #2
vadimt
agl@, could you provide OWNER's approval (previous reviewer is currently unavailable)?
6 years, 2 months ago (2014-10-09 19:28:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637733002/1
6 years, 2 months ago (2014-10-10 19:32:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 20:28:52 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/06b0b7030916fd66381d0c547c5916c1d0934161 Cr-Commit-Position: refs/heads/master@{#299176}
6 years, 2 months ago (2014-10-10 20:29:55 UTC) #9
agl
6 years, 2 months ago (2014-10-10 20:39:40 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698