Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 637583002: Add SkPaint::getHash(). (Closed)

Created:
6 years, 2 months ago by mtklein_C
Modified:
6 years, 2 months ago
Reviewers:
djsollen, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : iwyu #

Patch Set 3 : counting is hard #

Patch Set 4 : better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M include/core/SkPaint.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/core/SkPaint.cpp View 1 2 3 2 chunks +9 lines, -0 lines 0 comments Download
M tests/PaintTest.cpp View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
mtklein
6 years, 2 months ago (2014-10-07 15:22:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637583002/1
6 years, 2 months ago (2014-10-07 15:23:03 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-07 15:23:03 UTC) #5
commit-bot: I haz the power
Presubmit check for 637583002-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 2 months ago (2014-10-07 15:23:08 UTC) #7
reed1
lgtm
6 years, 2 months ago (2014-10-07 15:37:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637583002/20001
6 years, 2 months ago (2014-10-07 15:38:26 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/1733)
6 years, 2 months ago (2014-10-07 15:45:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637583002/60001
6 years, 2 months ago (2014-10-07 16:17:57 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 16:26:14 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as fb1fe4f51820731f557e765f8c71cba9a0d28048

Powered by Google App Engine
This is Rietveld 408576698