Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Side by Side Diff: src/code-stubs-hydrogen.cc

Issue 637553002: Fix for assertion failures appeared after StoreTransitionStub implementation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/objects-debug.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/bailout-reason.h" 7 #include "src/bailout-reason.h"
8 #include "src/code-stubs.h" 8 #include "src/code-stubs.h"
9 #include "src/field-index.h" 9 #include "src/field-index.h"
10 #include "src/hydrogen.h" 10 #include "src/hydrogen.h"
(...skipping 782 matching lines...) Expand 10 before | Expand all | Expand 10 after
793 Add<HConstant>((Page::kMaxRegularHeapObjectSize - 793 Add<HConstant>((Page::kMaxRegularHeapObjectSize -
794 FixedArray::kHeaderSize) >> 794 FixedArray::kHeaderSize) >>
795 ElementsKindToShiftSize(kind))); 795 ElementsKindToShiftSize(kind)));
796 796
797 // Reuse this code for properties backing store allocation. 797 // Reuse this code for properties backing store allocation.
798 HValue* new_properties = 798 HValue* new_properties =
799 BuildAllocateAndInitializeArray(kind, new_capacity); 799 BuildAllocateAndInitializeArray(kind, new_capacity);
800 800
801 BuildCopyProperties(properties, new_properties, length, new_capacity); 801 BuildCopyProperties(properties, new_properties, length, new_capacity);
802 802
803 // Store the new value into the "extended" object.
804 Add<HStoreNamedField>(object, HObjectAccess::ForPropertiesPointer(), 803 Add<HStoreNamedField>(object, HObjectAccess::ForPropertiesPointer(),
805 new_properties); 804 new_properties);
806 } 805 }
807 // Fall through. 806 // Fall through.
808 case StoreTransitionStub::StoreMapAndValue: 807 case StoreTransitionStub::StoreMapAndValue:
808 // Store the new value into the "extended" object.
809 BuildStoreNamedField( 809 BuildStoreNamedField(
810 object, GetParameter(StoreTransitionDescriptor::kValueIndex), 810 object, GetParameter(StoreTransitionDescriptor::kValueIndex),
811 casted_stub()->index(), casted_stub()->representation(), true); 811 casted_stub()->index(), casted_stub()->representation(), true);
812 // Fall through. 812 // Fall through.
813 813
814 case StoreTransitionStub::StoreMapOnly: 814 case StoreTransitionStub::StoreMapOnly:
815 // And finally update the map. 815 // And finally update the map.
816 Add<HStoreNamedField>(object, HObjectAccess::ForMap(), 816 Add<HStoreNamedField>(object, HObjectAccess::ForMap(),
817 GetParameter(StoreTransitionDescriptor::kMapIndex)); 817 GetParameter(StoreTransitionDescriptor::kMapIndex));
818 break; 818 break;
(...skipping 1193 matching lines...) Expand 10 before | Expand all | Expand 10 after
2012 2012
2013 // Probe the stub cache. 2013 // Probe the stub cache.
2014 Code::Flags flags = Code::RemoveTypeAndHolderFromFlags( 2014 Code::Flags flags = Code::RemoveTypeAndHolderFromFlags(
2015 Code::ComputeHandlerFlags(Code::LOAD_IC)); 2015 Code::ComputeHandlerFlags(Code::LOAD_IC));
2016 Add<HTailCallThroughMegamorphicCache>(receiver, name, flags); 2016 Add<HTailCallThroughMegamorphicCache>(receiver, name, flags);
2017 2017
2018 // We never continue. 2018 // We never continue.
2019 return graph()->GetConstant0(); 2019 return graph()->GetConstant0();
2020 } 2020 }
2021 } } // namespace v8::internal 2021 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/objects-debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698