Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 637533002: Added calls for deferred supervised user status change. (Closed)

Created:
6 years, 2 months ago by merkulova
Modified:
6 years, 2 months ago
CC:
chromium-reviews, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Added calls for deferred supervised user status change. For history see https://chromereviews.googleplex.com/96987013/ BUG=421039 Committed: https://crrev.com/57466b98c630fe481c03d94b12bebe4bfde40597 Cr-Commit-Position: refs/heads/master@{#298840}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code style. #

Patch Set 3 : Lost method added. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -9 lines) Patch
M chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 1 2 4 chunks +15 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 1 2 5 chunks +21 lines, -0 lines 0 comments Download
M components/user_manager/user_manager.h View 2 chunks +7 lines, -3 lines 0 comments Download
M components/user_manager/user_manager.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/user_manager/user_manager_base.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/user_manager/user_manager_base.cc View 1 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
merkulova
derat@ for system_tray_delegate_chromeos files review ygorshenin@ for user_manager files review
6 years, 2 months ago (2014-10-07 12:11:50 UTC) #2
ygorshenin1
lgtm
6 years, 2 months ago (2014-10-07 14:19:43 UTC) #3
Daniel Erat
https://codereview.chromium.org/637533002/diff/1/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc File chrome/browser/ui/ash/system_tray_delegate_chromeos.cc (right): https://codereview.chromium.org/637533002/diff/1/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc#newcode196 chrome/browser/ui/ash/system_tray_delegate_chromeos.cc:196: session_started_(false), do you need to check whether a session ...
6 years, 2 months ago (2014-10-07 16:19:19 UTC) #4
merkulova
https://codereview.chromium.org/637533002/diff/1/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc File chrome/browser/ui/ash/system_tray_delegate_chromeos.cc (right): https://codereview.chromium.org/637533002/diff/1/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc#newcode196 chrome/browser/ui/ash/system_tray_delegate_chromeos.cc:196: session_started_(false), On 2014/10/07 16:19:19, Daniel Erat wrote: > do ...
6 years, 2 months ago (2014-10-08 09:47:11 UTC) #5
Daniel Erat
lgtm
6 years, 2 months ago (2014-10-08 14:14:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637533002/20001
6 years, 2 months ago (2014-10-08 14:17:47 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/21973)
6 years, 2 months ago (2014-10-08 14:51:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637533002/40001
6 years, 2 months ago (2014-10-09 08:54:02 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 842952012ae77a4096bbe5c69a34be666e70fe32
6 years, 2 months ago (2014-10-09 10:55:33 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 10:56:36 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/57466b98c630fe481c03d94b12bebe4bfde40597
Cr-Commit-Position: refs/heads/master@{#298840}

Powered by Google App Engine
This is Rietveld 408576698