Rename websocket_handshake_stream_factory()

Rename websocket_handshake_stream_factory()

Rename net::HttpNetworkSession::websocket_handshake_stream_factory() to
http_stream_factory_for_websocket().

BUG=316477
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235689

[yhirano, 2013-11-08 11:14:13]

lgtm

[Adam Rice, 2013-11-11 05:00:49]

szym@chromium.org: Please review changes in net/http and the overall soundness
of the approach.

jam@chromium.org: Please review changes in chrome/ and the overall soundness of
the approach.

[jam, 2013-11-11 17:01:59]

On 2013/11/11 05:00:49, Adam Rice wrote:
> szym@chromium.org: Please review changes in net/http and the overall soundness
> of the approach.
> 
> jam@chromium.org: Please review changes in chrome/ and the overall soundness
of
> the approach.

are you sure? i'm not familiar with this code

[szym, 2013-11-11 17:08:36]

mmenke (who reviewed adding websocket_handshake_stream_factory()) would be the
best reviewer for the whole CL.

Personally, I don't think _for_http is adding any clarity, so I'd leave
http_stream_factory() as is.

[mmenke, 2013-11-11 18:30:32]

On 2013/11/11 17:08:36, szym wrote:
> mmenke (who reviewed adding websocket_handshake_stream_factory()) would be the
> best reviewer for the whole CL.
> 
> Personally, I don't think _for_http is adding any clarity, so I'd leave
> http_stream_factory() as is.

I agree that this doesn't seem to add any clarity.  One would generally expect
an HttpStreamFactory to be for http.  I don't think it'd actually be difficult
to just merge the two factories.

[szym, 2013-11-11 20:58:08]

On 2013/11/11 18:30:32, mmenke wrote:
> On 2013/11/11 17:08:36, szym wrote:
> > mmenke (who reviewed adding websocket_handshake_stream_factory()) would be
the
> > best reviewer for the whole CL.
> > 
> > Personally, I don't think _for_http is adding any clarity, so I'd leave
> > http_stream_factory() as is.
> 
> I agree that this doesn't seem to add any clarity.  One would generally expect
> an HttpStreamFactory to be for http.  I don't think it'd actually be difficult
> to just merge the two factories.

Filed: http://crbug.com/317858

[Adam Rice, 2013-11-12 01:45:23]

There appears to be consensus that the _for_http in
http_stream_factory_for_http() isn't needed, so I have reverted that part. PTAL.

[szym, 2013-11-14 03:22:10]

lgtm

[Adam Rice, 2013-11-18 05:16:47]

mmenke, do you have any comments?

[mmenke, 2013-11-18 05:25:58]

On 2013/11/18 05:16:47, Adam Rice wrote:
> mmenke, do you have any comments?

No, it's fine.  LGTM

[commit-bot: I haz the power, 2013-11-18 06:37:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ricea@chromium.org/63753004/210001

[commit-bot: I haz the power, 2013-11-18 10:55:28]

Change committed as 235689