Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 637503004: [webkitpy] Refactor diff_parser.py (Closed)

Created:
6 years, 2 months ago by elecro
Modified:
6 years, 2 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[webkitpy] Refactor diff_parser.py Precompile all regexes to eliminate self developed regex caching. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183448

Patch Set 1 #

Total comments: 2

Patch Set 2 : updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -25 lines) Patch
M Tools/Scripts/webkitpy/common/checkout/diff_parser.py View 1 5 chunks +14 lines, -25 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
elecro
PTAL
6 years, 2 months ago (2014-10-07 18:07:43 UTC) #2
Dirk Pranke
https://codereview.chromium.org/637503004/diff/1/Tools/Scripts/webkitpy/common/checkout/diff_parser.py File Tools/Scripts/webkitpy/common/checkout/diff_parser.py (right): https://codereview.chromium.org/637503004/diff/1/Tools/Scripts/webkitpy/common/checkout/diff_parser.py#newcode90 Tools/Scripts/webkitpy/common/checkout/diff_parser.py:90: diff_git_pattern = re.compile(r"^diff --git \w/") I'm not generally a ...
6 years, 2 months ago (2014-10-08 01:45:47 UTC) #3
elecro
https://codereview.chromium.org/637503004/diff/1/Tools/Scripts/webkitpy/common/checkout/diff_parser.py File Tools/Scripts/webkitpy/common/checkout/diff_parser.py (right): https://codereview.chromium.org/637503004/diff/1/Tools/Scripts/webkitpy/common/checkout/diff_parser.py#newcode90 Tools/Scripts/webkitpy/common/checkout/diff_parser.py:90: diff_git_pattern = re.compile(r"^diff --git \w/") On 2014/10/08 01:45:47, Dirk ...
6 years, 2 months ago (2014-10-08 08:14:16 UTC) #4
elecro
updated
6 years, 2 months ago (2014-10-08 10:19:47 UTC) #5
Dirk Pranke
Thanks! I suspect the fixmes were from a time when we thought differently about static ...
6 years, 2 months ago (2014-10-08 14:17:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637503004/20001
6 years, 2 months ago (2014-10-09 07:56:16 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 10:18:10 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183448

Powered by Google App Engine
This is Rietveld 408576698