Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 637493002: Clean up ifdef around FilePath creation in /src/content (Closed)

Created:
6 years, 2 months ago by anujsharma
Modified:
6 years, 2 months ago
CC:
chromium-reviews, MRV
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Clean up ifdef around FilePath creation in /src/content BUG=102853 Committed: https://crrev.com/3a58e5c63ec758b5aa3e9a90f4aa67029de713d9 Cr-Commit-Position: refs/heads/master@{#298812}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed comment #

Patch Set 3 : Fixing build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M content/renderer/pepper/pepper_file_chooser_host.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
anujsharma
PTAL
6 years, 2 months ago (2014-10-07 13:05:19 UTC) #2
jochen (gone - plz use gerrit)
lgtm once it's formatted https://codereview.chromium.org/637493002/diff/1/content/browser/download/save_package.cc File content/browser/download/save_package.cc (right): https://codereview.chromium.org/637493002/diff/1/content/browser/download/save_package.cc#newcode1296 content/browser/download/save_package.cc:1296: base::FilePath::StringType::FromUTF8Unsafe(contents_mime_type); please clang-format this
6 years, 2 months ago (2014-10-08 14:10:32 UTC) #3
anujsharma
On 2014/10/08 14:10:32, jochen wrote: > lgtm once it's formatted > > https://codereview.chromium.org/637493002/diff/1/content/browser/download/save_package.cc > File ...
6 years, 2 months ago (2014-10-08 14:17:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637493002/20001
6 years, 2 months ago (2014-10-08 14:22:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/22870)
6 years, 2 months ago (2014-10-08 14:35:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637493002/40001
6 years, 2 months ago (2014-10-09 05:03:41 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001) as b8948e8aceb72e753352d3ea4be4d822cdd2b3b3
6 years, 2 months ago (2014-10-09 06:13:10 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 06:14:18 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3a58e5c63ec758b5aa3e9a90f4aa67029de713d9
Cr-Commit-Position: refs/heads/master@{#298812}

Powered by Google App Engine
This is Rietveld 408576698