Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 637483002: Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/xml (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Mike West, dcheng
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/xml This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183338

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -204 lines) Patch
M Source/core/xml/DOMParser.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/DocumentXPathEvaluator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/xml/NativeXPathNSResolver.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/xml/XMLHttpRequest.h View 5 chunks +17 lines, -17 lines 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/xml/XMLHttpRequestProgressEvent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/xml/XMLHttpRequestProgressEventThrottle.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/xml/XMLHttpRequestUpload.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/xml/XMLSerializer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XPathEvaluator.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XPathExpressionNode.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XPathFunctions.cpp View 1 chunk +81 lines, -81 lines 0 comments Download
M Source/core/xml/XPathPath.h View 1 chunk +12 lines, -12 lines 0 comments Download
M Source/core/xml/XPathPredicate.h View 2 chunks +24 lines, -24 lines 0 comments Download
M Source/core/xml/XPathResult.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XPathStep.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/xml/XPathVariableReference.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/xml/XSLImportRule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XSLStyleSheet.h View 3 chunks +12 lines, -12 lines 0 comments Download
M Source/core/xml/parser/XMLDocumentParser.h View 4 chunks +12 lines, -12 lines 0 comments Download
M Source/core/xml/parser/XMLDocumentParser.cpp View 12 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-07 12:10:44 UTC) #2
Mike West
rs lgtm.
6 years, 2 months ago (2014-10-07 12:55:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637483002/1
6 years, 2 months ago (2014-10-07 13:20:24 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 14:27:46 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 183338

Powered by Google App Engine
This is Rietveld 408576698