Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 637473002: Replacing the OVERRIDE with override and FINAL with final in content/browser/geolocation/web_conten… (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing the OVERRIDE with override and FINAL with final in content/browser/geolocation/web_contents This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/7578760a31769aec803568a7b2dd7f90750b7580 Cr-Commit-Position: refs/heads/master@{#298516}

Patch Set 1 #

Patch Set 2 : Rebased the patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+521 lines, -521 lines) Patch
M content/browser/web_contents/aura/gesture_nav_simple.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/web_contents/aura/gesture_nav_simple.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/web_contents/aura/image_window_delegate.h View 1 chunk +15 lines, -15 lines 0 comments Download
M content/browser/web_contents/aura/overscroll_navigation_overlay.h View 1 chunk +8 lines, -8 lines 0 comments Download
M content/browser/web_contents/aura/overscroll_navigation_overlay.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/aura/shadow_layer_delegate.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/web_contents/aura/window_slider.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/web_contents/aura/window_slider.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/aura/window_slider_unittest.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M content/browser/web_contents/opened_by_dom_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura.h View 1 chunk +22 lines, -22 lines 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura_browsertest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 6 chunks +249 lines, -249 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl_browsertest.cc View 8 chunks +11 lines, -11 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 9 chunks +17 lines, -17 lines 0 comments Download
M content/browser/web_contents/web_contents_view_android.h View 2 chunks +25 lines, -25 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.h View 1 chunk +52 lines, -52 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 11 chunks +13 lines, -13 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura_browsertest.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M content/browser/web_contents/web_contents_view_guest.h View 1 chunk +27 lines, -27 lines 0 comments Download
M content/browser/web_contents/web_contents_view_mac.h View 2 chunks +29 lines, -29 lines 0 comments Download
M content/browser/web_contents/web_contents_view_overscroll_animator_slider_mac.mm View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-07 06:54:27 UTC) #2
Avi (use Gerrit)
Stampity stamp LGTM
6 years, 2 months ago (2014-10-07 14:25:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637473002/20001
6 years, 2 months ago (2014-10-07 14:56:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/21167)
6 years, 2 months ago (2014-10-07 16:29:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637473002/20001
6 years, 2 months ago (2014-10-07 17:26:51 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 28bd6002cb6436b15c4f0283ea8e1c9463fa99d0
6 years, 2 months ago (2014-10-07 17:31:09 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 17:32:09 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7578760a31769aec803568a7b2dd7f90750b7580
Cr-Commit-Position: refs/heads/master@{#298516}

Powered by Google App Engine
This is Rietveld 408576698