Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 637463002: Revert "Remote Assistance on Chrome OS Part III - NativeMessageHost" (Closed)

Created:
6 years, 2 months ago by hayato
Modified:
6 years, 2 months ago
Reviewers:
CC:
chromium-reviews, mkwst+moarreviews-ipc_chromium.org, chromium-apps-reviews_chromium.org, chromoting-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+309 lines, -756 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +1 line, -9 lines 0 comments Download
M chrome/browser/extensions/api/messaging/message_service.h View 4 chunks +10 lines, -13 lines 0 comments Download
M chrome/browser/extensions/api/messaging/message_service.cc View 6 chunks +18 lines, -54 lines 0 comments Download
D chrome/browser/extensions/api/messaging/native_message_host_chromeos.cc View 1 chunk +0 lines, -152 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_port.h View 1 chunk +4 lines, -18 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_port.cc View 1 chunk +8 lines, -101 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_process_host.h View 6 chunks +49 lines, -14 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_process_host.cc View 14 chunks +94 lines, -43 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc View 11 chunks +38 lines, -54 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/test/data/extensions/api_test/native_messaging/test.js View 1 chunk +5 lines, -2 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D extensions/browser/api/messaging/native_message_host.h View 1 chunk +0 lines, -62 lines 0 comments Download
D extensions/browser/api/messaging/native_message_host.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M extensions/common/switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/it2me/com.google.chrome.remote_assistance.json.jinja2 View 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/host/it2me/it2me_native_messaging_host.h View 2 chunks +22 lines, -17 lines 0 comments Download
M remoting/host/it2me/it2me_native_messaging_host.cc View 11 chunks +31 lines, -29 lines 0 comments Download
M remoting/host/it2me/it2me_native_messaging_host_main.cc View 2 chunks +3 lines, -12 lines 0 comments Download
M remoting/host/it2me/it2me_native_messaging_host_unittest.cc View 7 chunks +13 lines, -20 lines 0 comments Download
D remoting/host/native_messaging/native_messaging_pipe.h View 1 chunk +0 lines, -50 lines 0 comments Download
D remoting/host/native_messaging/native_messaging_pipe.cc View 1 chunk +0 lines, -52 lines 0 comments Download
M remoting/remoting_host.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637463002/1
6 years, 2 months ago (2014-10-07 06:36:17 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-10-07 06:36:18 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a116270a9656e92964a7ea5fd56ba9a2c3f67298 Cr-Commit-Position: refs/heads/master@{#298404}
6 years, 2 months ago (2014-10-07 06:39:21 UTC) #5
hayato
6 years, 2 months ago (2014-10-07 06:39:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a116270a9656e92964a7ea5fd56ba9a2c3f67298 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698