Issue 637383004: Fix crash from DescendantInvalidationSet::show().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 637383004: Fix crash from DescendantInvalidationSet::show(). (Closed)

Created:
6 years, 2 months ago by rune

Modified:
6 years, 2 months ago

Reviewers:
kouhei (in TOK)

CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Fix crash from DescendantInvalidationSet::show(). Adding a dictionary without a name to TracedValue without being inside an array asserts. Added an array around the invalidation set to avoid that crash from DescendantInvalidationSet::show() which is used for debugging. R=kouhei@chromium.org BUG=425577 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184097

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	Source/core/css/invalidation/DescendantInvalidationSet.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	Source/core/css/invalidation/DescendantInvalidationSetTest.cpp	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637383004/1

6 years, 2 months ago (2014-10-21 16:03:31 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-21 17:04:58 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 184097

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages