mojo/public/tools/bindings/generators/js_templates/module.js.tmpl - Issue 637373002: Mojo JS bindings: simplify mojo.connectToService() usage - Part 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/js_templates/module.js.tmpl

Issue 637373002: Mojo JS bindings: simplify mojo.connectToService() usage - Part 2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Renamed the mojo_internals module, made Connection localFactory optional Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl ('k') | mojo/public/tools/bindings/generators/mojom_js_generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/js_templates/module.js.tmpl

diff --git a/mojo/public/tools/bindings/generators/js_templates/module.js.tmpl b/mojo/public/tools/bindings/generators/js_templates/module.js.tmpl

index 397a12054624925bf573cdbca83aa26e2878f910..058bc1e70d0349ff66f831b1f7849fbc6e929d57 100644

--- a/mojo/public/tools/bindings/generators/js_templates/module.js.tmpl

+++ b/mojo/public/tools/bindings/generators/js_templates/module.js.tmpl

@@ -50,6 +50,8 @@ define("{{module.path}}", [

{#--- Interface Client #}

{%- if interface.client in interfaces|map(attribute='name') %}

exports.{{interface.name}}.client = {{interface.client}};

+{%- elif interface.client in imported_interfaces %}

+ exports.{{interface.name}}.client = {{imported_interfaces[interface.client]}};

{%- endif %}

{%- endfor %}