mojo/public/js/bindings/connection.js - Issue 637373002: Mojo JS bindings: simplify mojo.connectToService() usage - Part 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/js/bindings/connection.js

Issue 637373002: Mojo JS bindings: simplify mojo.connectToService() usage - Part 2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Renamed the mojo_internals module, made Connection localFactory optional Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/public/js/bindings/connection.js

diff --git a/mojo/public/js/bindings/connection.js b/mojo/public/js/bindings/connection.js

index 01e33e95cd25743accd0719a5088819e61ef1fcf..7d92e8c76d9c126fd5278d4fcd3fd57d9674ecdf 100644

--- a/mojo/public/js/bindings/connection.js

+++ b/mojo/public/js/bindings/connection.js

@@ -13,11 +13,11 @@ define("mojo/public/js/bindings/connection", [

routerFactory = router.Router;

this.router_ = new routerFactory(handle, connectorFactory);

this.remote = new remoteFactory(this.router_);

- this.local = new localFactory(this.remote);

+ this.local = localFactory && new localFactory(this.remote);

this.router_.setIncomingReceiver(this.local);

// Validate incoming messages: remote responses and local requests.

- var validateRequest = localFactory.prototype.validator;

+ var validateRequest = localFactory && localFactory.prototype.validator;

var validateResponse = remoteFactory.prototype.validator;

var payloadValidators = [];

if (validateRequest)

« no previous file with comments | « mojo/mojo_apps.gypi ('k') | mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl » ('j') | no next file with comments »