Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1391)

Unified Diff: mojo/apps/js/mojo_bridge_module.cc

Issue 637373002: Mojo JS bindings: simplify mojo.connectToService() usage - Part 2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Renamed the mojo_internals module, made Connection localFactory optional Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/apps/js/mojo_bridge_module.h ('k') | mojo/apps/js/mojo_module.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/apps/js/mojo_bridge_module.cc
diff --git a/mojo/apps/js/mojo_module.cc b/mojo/apps/js/mojo_bridge_module.cc
similarity index 82%
rename from mojo/apps/js/mojo_module.cc
rename to mojo/apps/js/mojo_bridge_module.cc
index d3c0f760d2f7ecdd4ccd0e3d9a4604bd3afe95d3..691a1e8c04d9a7154260b1f4daaf448fd520bc7a 100644
--- a/mojo/apps/js/mojo_module.cc
+++ b/mojo/apps/js/mojo_bridge_module.cc
@@ -2,16 +2,14 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "mojo/apps/js/mojo_module.h"
+#include "mojo/apps/js/mojo_bridge_module.h"
#include "gin/arguments.h"
#include "gin/converter.h"
#include "gin/object_template_builder.h"
#include "gin/per_isolate_data.h"
#include "mojo/apps/js/js_app.h"
-#include "mojo/apps/js/mojo_module.h"
#include "mojo/bindings/js/handle.h"
-#include "mojo/common/data_pipe_utils.h"
namespace mojo {
namespace apps {
@@ -22,9 +20,10 @@ gin::WrapperInfo g_wrapper_info = {gin::kEmbedderNativeGin};
} // namespace
-const char Mojo::kModuleName[] = "mojo";
+const char MojoInternals::kModuleName[] = "mojo/apps/js/bridge";
-v8::Local<v8::Value> Mojo::GetModule(JSApp* js_app, v8::Isolate* isolate) {
+v8::Local<v8::Value> MojoInternals::GetModule(JSApp* js_app,
+ v8::Isolate* isolate) {
gin::PerIsolateData* data = gin::PerIsolateData::From(isolate);
v8::Local<v8::ObjectTemplate> templ =
data->GetObjectTemplate(&g_wrapper_info);
« no previous file with comments | « mojo/apps/js/mojo_bridge_module.h ('k') | mojo/apps/js/mojo_module.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698