mojo/apps/js/js_app.cc - Issue 637373002: Mojo JS bindings: simplify mojo.connectToService() usage - Part 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/apps/js/js_app.cc

Issue 637373002: Mojo JS bindings: simplify mojo.connectToService() usage - Part 2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Renamed the mojo_internals module, made Connection localFactory optional Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/apps/js/js_app.cc

diff --git a/mojo/apps/js/js_app.cc b/mojo/apps/js/js_app.cc

index 7b400b24878c35167314fa82e7730e45166f9bba..f3550fa2530719b32958793e8e361bce7ce86260 100644

--- a/mojo/apps/js/js_app.cc

+++ b/mojo/apps/js/js_app.cc

@@ -8,7 +8,7 @@

#include "gin/array_buffer.h"

#include "gin/converter.h"

#include "mojo/apps/js/application_delegate_impl.h"

-#include "mojo/apps/js/mojo_module.h"

+#include "mojo/apps/js/mojo_bridge_module.h"

namespace mojo {

namespace apps {

@@ -19,8 +19,8 @@ JSApp::JSApp(ApplicationDelegateImpl* app_delegate_impl)

app_delegate_impl_task_runner_(

base::MessageLoop::current()->task_runner()) {

CHECK(on_app_delegate_impl_thread());

- runner_delegate_.AddBuiltinModule(Mojo::kModuleName,

- base::Bind(Mojo::GetModule, this));

+ runner_delegate_.AddBuiltinModule(MojoInternals::kModuleName,

+ base::Bind(MojoInternals::GetModule, this));

}

JSApp::~JSApp() {

« no previous file with comments | « mojo/apps/js/js_app.h ('k') | mojo/apps/js/main.js » ('j') | no next file with comments »