Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: mojo/apps/js/mojo_module.cc

Issue 637373002: Mojo JS bindings: simplify mojo.connectToService() usage - Part 2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Renamed the mojo_internals module, made Connection localFactory optional Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/apps/js/mojo_module.h ('k') | mojo/mojo_apps.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/apps/js/mojo_module.cc
diff --git a/mojo/apps/js/mojo_module.cc b/mojo/apps/js/mojo_module.cc
deleted file mode 100644
index d3c0f760d2f7ecdd4ccd0e3d9a4604bd3afe95d3..0000000000000000000000000000000000000000
--- a/mojo/apps/js/mojo_module.cc
+++ /dev/null
@@ -1,47 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "mojo/apps/js/mojo_module.h"
-
-#include "gin/arguments.h"
-#include "gin/converter.h"
-#include "gin/object_template_builder.h"
-#include "gin/per_isolate_data.h"
-#include "mojo/apps/js/js_app.h"
-#include "mojo/apps/js/mojo_module.h"
-#include "mojo/bindings/js/handle.h"
-#include "mojo/common/data_pipe_utils.h"
-
-namespace mojo {
-namespace apps {
-
-namespace {
-
-gin::WrapperInfo g_wrapper_info = {gin::kEmbedderNativeGin};
-
-} // namespace
-
-const char Mojo::kModuleName[] = "mojo";
-
-v8::Local<v8::Value> Mojo::GetModule(JSApp* js_app, v8::Isolate* isolate) {
- gin::PerIsolateData* data = gin::PerIsolateData::From(isolate);
- v8::Local<v8::ObjectTemplate> templ =
- data->GetObjectTemplate(&g_wrapper_info);
-
- if (templ.IsEmpty()) {
- templ = gin::ObjectTemplateBuilder(isolate)
- .SetMethod("connectToService",
- base::Bind(&JSApp::ConnectToService,
- base::Unretained(js_app)))
- .SetMethod("quit",
- base::Bind(&JSApp::Quit, base::Unretained(js_app)))
- .Build();
- data->SetObjectTemplate(&g_wrapper_info, templ);
- }
-
- return templ->NewInstance();
-}
-
-} // namespace apps
-} // namespace mojo
« no previous file with comments | « mojo/apps/js/mojo_module.h ('k') | mojo/mojo_apps.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698