Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 637353004: Remove obsoleted term, "content_shell". (Closed)

Created:
6 years, 2 months ago by byungchul
Modified:
6 years, 2 months ago
Reviewers:
lcwu1, gunsch
CC:
chromium-reviews, vsevik, lcwu+watch_chromium.org, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove obsoleted term, "content_shell". 1) Replace android remote debugging unix domain socket path with cast_shell_debugging_remote. 2) Fix sandbox permission name correctly. BUG=425615 Committed: https://crrev.com/1d83ee8d763b534d8088f7b4a922caa0f23cff56 Cr-Commit-Position: refs/heads/master@{#300555}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chromecast/browser/android/apk/AndroidManifest.xml View 1 chunk +7 lines, -7 lines 0 comments Download
M chromecast/browser/devtools/remote_debugging_server.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
byungchul
6 years, 2 months ago (2014-10-21 17:56:35 UTC) #2
lcwu1
lgtm
6 years, 2 months ago (2014-10-21 18:01:03 UTC) #3
gunsch
lgtm
6 years, 2 months ago (2014-10-21 19:15:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637353004/1
6 years, 2 months ago (2014-10-21 20:06:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 21:04:41 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 21:05:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d83ee8d763b534d8088f7b4a922caa0f23cff56
Cr-Commit-Position: refs/heads/master@{#300555}

Powered by Google App Engine
This is Rietveld 408576698