Issue 637353003: pre-build the resources library for the fiddle jail

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 637353003: pre-build the resources library for the fiddle jail (Closed)

Created:
6 years, 2 months ago by humper

Modified:
6 years, 2 months ago

Reviewers:
tfarina, jcgregorio, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

pre-build the resources library for the fiddle jail BUG=skia: TBR=jcgregorio Committed: https://skia.googlesource.com/skia/+/4f6ffde95fb74c1bdb9b223e65944528a972742b

Patch Set 1 #

Total comments: 2

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	experimental/webtry/setup/continue_install_jail.sh	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

humper

Committed patchset #1 (id:1) manually as 4f6ffde95fb74c1bdb9b223e65944528a972742b (presubmit successful).

6 years, 2 months ago (2014-10-08 16:36:46 UTC) #1

tfarina

6 years, 2 months ago (2014-10-08 19:26:40 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/637353003/diff/1/experimental/webtry/setup/co...
File experimental/webtry/setup/continue_install_jail.sh (right):

https://codereview.chromium.org/637353003/diff/1/experimental/webtry/setup/co...
experimental/webtry/setup/continue_install_jail.sh:39:
SKIA_GYP_OUTPUT_DIR=${SKIA_BUILD}/skia/out GYP_GENERATORS=ninja ./gyp_skia
-Dskia_gpu=0
I think we can remove GYP_GENERATORS=ninja.

It seems to be the default on Linux:
https://skia.googlesource.com/skia/+/master/gyp_skia#96

https://codereview.chromium.org/637353003/diff/1/experimental/webtry/setup/co...
experimental/webtry/setup/continue_install_jail.sh:41: ninja -C
${SKIA_BUILD}/skia/out/Release skia_lib libjpeg libSkKTX libetc1 flags
sk_tool_utils resources
lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages