Add Search Service in Enhanced Bookmark Bridge

chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h

Index: chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h
diff --git a/chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h b/chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h
index 75c1efe798633585271da4847f76f691bddfaa70..de55ebf979607c441979007ba4d068455edf2196 100644
--- a/chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h
+++ b/chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h
@@ -9,6 +9,7 @@
 #include "base/android/jni_weak_ref.h"
 #include "chrome/browser/profiles/profile.h"
 #include "components/bookmarks/browser/bookmark_model.h"
+#include "components/enhanced_bookmarks/bookmark_server_search_service.h"
 #include "components/enhanced_bookmarks/bookmark_server_service.h"
 
 namespace enhanced_bookmarks {
@@ -28,12 +29,12 @@ class EnhancedBookmarksBridge : public BookmarkServerServiceObserver {
       jobject obj,
       jlong id,
       jint type);
-
   void SetBookmarkDescription(JNIEnv* env,
                               jobject obj,
                               jlong id,
                               jint type,
                               jstring description);
+
   void GetBookmarksForFilter(JNIEnv* env,
                              jobject obj,
                              jstring filter,
@@ -41,14 +42,17 @@ class EnhancedBookmarksBridge : public BookmarkServerServiceObserver {
   base::android::ScopedJavaLocalRef<jobjectArray> GetFilters(JNIEnv* env,
                                                              jobject obj);
 
+  void SendSearchRequest(JNIEnv* env, jobject obj, jstring j_query);
+
   // BookmarkServerServiceObserver
-  // Called on changes to cluster data
+  // Called on changes to cluster data or search results are returned.
   virtual void OnChange(BookmarkServerService* service) override;
 
  private:
   JavaObjectWeakGlobalRef weak_java_ref_;
   BookmarkModel* bookmark_model_;  // weak
   BookmarkServerClusterService* cluster_service_;  // weak
+  BookmarkServerSearchService* search_service_;

[lpromero, 2014/10/29 10:31:35]

You could use either a scoped_ptr or not making it a pointer at all, no?

[noyau (Ping after 24h), 2014/10/29 12:49:48]

I'm not sure it is the right scope here. The search service should be short
lived, as soon as the UI which needs it goes away it should be deleted. By tying
up to the enhancedBookmark this implies that it will stay up for the life of the
app? If this is the case, this is not its intended use.

I would suggest giving the search service a bridge of its own, which is released
ASAP.

[Ian Wen, 2014/10/29 21:54:36]

Here search_service has a MRUCache in it for faster results. Maybe at least for
this reason we should let the service to live a bit longer. I would make the
service scoped here. ;)

[Kibeom Kim (inactive), 2014/10/30 03:13:11]

We destroy EnhancedBookmarksBridge once the bookmark UI dialog is closed. Maybe
destroying |search_service_| at closing search UI is more ideal but I think the
current lifetime is acceptable.

   Profile* profile_;                       // weak
   DISALLOW_COPY_AND_ASSIGN(EnhancedBookmarksBridge);
 };