Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc

Issue 637323005: Add Search Service in Enhanced Bookmark Bridge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc
diff --git a/chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc b/chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc
index 7cc408b75ef3de127aa063aab00cb9d935a5eb8d..49765edf4cc60a288c688684a18e35ae2ae1e530 100644
--- a/chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc
+++ b/chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc
@@ -9,11 +9,16 @@
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
#include "chrome/browser/enhanced_bookmarks/chrome_bookmark_server_cluster_service.h"
#include "chrome/browser/enhanced_bookmarks/chrome_bookmark_server_cluster_service_factory.h"
+#include "chrome/browser/enhanced_bookmarks/enhanced_bookmark_model_factory.h"
#include "chrome/browser/profiles/profile_android.h"
+#include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
+#include "chrome/browser/signin/signin_manager_factory.h"
#include "components/bookmarks/browser/bookmark_model.h"
#include "components/bookmarks/browser/bookmark_utils.h"
#include "components/bookmarks/common/android/bookmark_type.h"
+#include "components/enhanced_bookmarks/enhanced_bookmark_model.h"
#include "components/enhanced_bookmarks/metadata_accessor.h"
+#include "components/signin/core/browser/signin_manager.h"
#include "jni/EnhancedBookmarksBridge_jni.h"
using base::android::AttachCurrentThread;
@@ -30,10 +35,18 @@ EnhancedBookmarksBridge::EnhancedBookmarksBridge(JNIEnv* env,
cluster_service_ =
ChromeBookmarkServerClusterServiceFactory::GetForBrowserContext(profile_);
cluster_service_->AddObserver(this);
+ search_service_ = new BookmarkServerSearchService(
+ profile_->GetRequestContext(),
+ ProfileOAuth2TokenServiceFactory::GetForProfile(profile_),
+ SigninManagerFactory::GetForProfile(profile_),
+ EnhancedBookmarkModelFactory::GetForBrowserContext(profile_));
+ search_service_->AddObserver(this);
}
EnhancedBookmarksBridge::~EnhancedBookmarksBridge() {
cluster_service_->RemoveObserver(this);
+ search_service_->RemoveObserver(this);
+ delete search_service_;
}
void EnhancedBookmarksBridge::Destroy(JNIEnv*, jobject) {
@@ -89,11 +102,30 @@ ScopedJavaLocalRef<jobjectArray> EnhancedBookmarksBridge::GetFilters(
JNIEnv* env,
jobject obj) {
DCHECK(bookmark_model_->loaded());
- const std::vector<std::string> filters =
- cluster_service_->GetClusters();
+ const std::vector<std::string> filters = cluster_service_->GetClusters();
return base::android::ToJavaArrayOfStrings(env, filters);
}
+void EnhancedBookmarksBridge::SendSearchRequest(JNIEnv* env,
+ jobject obj,
+ jstring j_query) {
+ search_service_->Search(base::android::ConvertJavaStringToUTF8(env, j_query));
+}
+
+void EnhancedBookmarksBridge::GetSearchResults(
+ JNIEnv* env,
+ jobject obj,
+ jobject j_list,
+ jstring j_query) {
+ DCHECK(bookmark_model_->loaded());
+ std::vector<const BookmarkNode*> results = search_service_->ResultForQuery(
+ base::android::ConvertJavaStringToUTF8(env, j_query));
+ for (const BookmarkNode* node : results) {
+ Java_EnhancedBookmarksBridge_addToBookmarkIdList(
+ env, j_list, node->id(), node->type());
Ted C 2014/10/23 00:31:42 indented too much
Ian Wen 2014/10/29 00:11:39 Function deleted.
+ }
+}
+
void EnhancedBookmarksBridge::OnChange(BookmarkServerService* service) {
DCHECK(bookmark_model_->loaded());
JNIEnv* env = AttachCurrentThread();
@@ -102,7 +134,11 @@ void EnhancedBookmarksBridge::OnChange(BookmarkServerService* service) {
if (obj.is_null())
return;
- Java_EnhancedBookmarksBridge_onFiltersChanged(env, obj.obj());
+ if (service == cluster_service_) {
+ Java_EnhancedBookmarksBridge_onFiltersChanged(env, obj.obj());
+ } else if (service == search_service_){
+ Java_EnhancedBookmarksBridge_onSearchResultReturned(env, obj.obj());
+ }
}
static jlong Init(JNIEnv* env, jobject obj, jobject j_profile) {

Powered by Google App Engine
This is Rietveld 408576698