Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2014 The Chromium Authors. All rights reserved. | 1 // Copyright 2014 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #ifndef CHROME_BROWSER_ANDROID_ENHANCED_BOOKMARKS_ENHANCED_BOOKMARKS_BRIDGE_H_ | 5 #ifndef CHROME_BROWSER_ANDROID_ENHANCED_BOOKMARKS_ENHANCED_BOOKMARKS_BRIDGE_H_ |
| 6 #define CHROME_BROWSER_ANDROID_ENHANCED_BOOKMARKS_ENHANCED_BOOKMARKS_BRIDGE_H_ | 6 #define CHROME_BROWSER_ANDROID_ENHANCED_BOOKMARKS_ENHANCED_BOOKMARKS_BRIDGE_H_ |
| 7 | 7 |
| 8 #include "base/android/jni_android.h" | 8 #include "base/android/jni_android.h" |
| 9 #include "base/android/jni_weak_ref.h" | 9 #include "base/android/jni_weak_ref.h" |
| 10 #include "chrome/browser/profiles/profile.h" | 10 #include "chrome/browser/profiles/profile.h" |
| 11 #include "components/bookmarks/browser/bookmark_model.h" | 11 #include "components/bookmarks/browser/bookmark_model.h" |
| 12 #include "components/enhanced_bookmarks/bookmark_server_search_service.h" | |
| 12 #include "components/enhanced_bookmarks/bookmark_server_service.h" | 13 #include "components/enhanced_bookmarks/bookmark_server_service.h" |
| 13 | 14 |
| 14 namespace enhanced_bookmarks { | 15 namespace enhanced_bookmarks { |
| 15 | 16 |
| 16 class BookmarkServerClusterService; | 17 class BookmarkServerClusterService; |
| 17 | 18 |
| 18 namespace android { | 19 namespace android { |
| 19 | 20 |
| 20 class EnhancedBookmarksBridge : public BookmarkServerServiceObserver { | 21 class EnhancedBookmarksBridge : public BookmarkServerServiceObserver { |
| 21 public: | 22 public: |
| 22 EnhancedBookmarksBridge(JNIEnv* env, jobject obj, Profile* profile); | 23 EnhancedBookmarksBridge(JNIEnv* env, jobject obj, Profile* profile); |
| 23 virtual ~EnhancedBookmarksBridge(); | 24 virtual ~EnhancedBookmarksBridge(); |
| 24 void Destroy(JNIEnv*, jobject); | 25 void Destroy(JNIEnv*, jobject); |
| 25 | 26 |
| 26 base::android::ScopedJavaLocalRef<jstring> GetBookmarkDescription( | 27 base::android::ScopedJavaLocalRef<jstring> GetBookmarkDescription( |
| 27 JNIEnv* env, | 28 JNIEnv* env, |
| 28 jobject obj, | 29 jobject obj, |
| 29 jlong id, | 30 jlong id, |
| 30 jint type); | 31 jint type); |
| 31 | |
| 32 void SetBookmarkDescription(JNIEnv* env, | 32 void SetBookmarkDescription(JNIEnv* env, |
| 33 jobject obj, | 33 jobject obj, |
| 34 jlong id, | 34 jlong id, |
| 35 jint type, | 35 jint type, |
| 36 jstring description); | 36 jstring description); |
| 37 | |
| 37 void GetBookmarksForFilter(JNIEnv* env, | 38 void GetBookmarksForFilter(JNIEnv* env, |
| 38 jobject obj, | 39 jobject obj, |
| 39 jstring filter, | 40 jstring filter, |
| 40 jobject j_result_obj); | 41 jobject j_result_obj); |
| 41 base::android::ScopedJavaLocalRef<jobjectArray> GetFilters(JNIEnv* env, | 42 base::android::ScopedJavaLocalRef<jobjectArray> GetFilters(JNIEnv* env, |
| 42 jobject obj); | 43 jobject obj); |
| 43 | 44 |
| 45 void SendSearchRequest(JNIEnv* env, jobject obj, jstring j_query); | |
| 46 void GetSearchResults(JNIEnv* env, | |
| 47 jobject obj, | |
| 48 jobject j_list, | |
| 49 jstring j_query); | |
| 50 | |
| 44 // BookmarkServerServiceObserver | 51 // BookmarkServerServiceObserver |
| 45 // Called on changes to cluster data | 52 // Called on changes to cluster data or search results are returned. |
| 46 virtual void OnChange(BookmarkServerService* service) override; | 53 virtual void OnChange(BookmarkServerService* service) override; |
| 47 | 54 |
| 48 private: | 55 private: |
| 49 JavaObjectWeakGlobalRef weak_java_ref_; | 56 JavaObjectWeakGlobalRef weak_java_ref_; |
| 50 BookmarkModel* bookmark_model_; // weak | 57 BookmarkModel* bookmark_model_; // weak |
| 51 BookmarkServerClusterService* cluster_service_; // weak | 58 BookmarkServerClusterService* cluster_service_; // weak |
| 59 BookmarkServerSearchService* search_service_; | |
|
Kibeom Kim (inactive)
2014/10/22 18:42:01
Let's make it scoped_ptr
Ian Wen
2014/10/29 00:11:39
This service should never be deleted.
Kibeom Kim (inactive)
2014/10/29 07:51:46
But it looks you're deleting in enhanced_bookmarks
Ian Wen
2014/10/29 21:54:35
Made it scoped ptr
| |
| 52 Profile* profile_; // weak | 60 Profile* profile_; // weak |
| 53 DISALLOW_COPY_AND_ASSIGN(EnhancedBookmarksBridge); | 61 DISALLOW_COPY_AND_ASSIGN(EnhancedBookmarksBridge); |
| 54 }; | 62 }; |
| 55 | 63 |
| 56 bool RegisterEnhancedBookmarksBridge(JNIEnv* env); | 64 bool RegisterEnhancedBookmarksBridge(JNIEnv* env); |
| 57 | 65 |
| 58 } // namespace android | 66 } // namespace android |
| 59 } // namespace enhanced_bookmarks | 67 } // namespace enhanced_bookmarks |
| 60 | 68 |
| 61 #endif // CHROME_BROWSER_ANDROID_ENHANCED_BOOKMARKS_ENHANCED_BOOKMARKS_BRIDGE_H _ | 69 #endif // CHROME_BROWSER_ANDROID_ENHANCED_BOOKMARKS_ENHANCED_BOOKMARKS_BRIDGE_H _ |
| OLD | NEW |